Add timeouts to the aws_networkfirewall_firewall resource

[alexknez]

Description

This change allows users to change the timeout for the user creation, default time is 30 minutes.

resource "aws_networkfirewall_firewall" "example" {
  name                = "example"
  firewall_policy_arn = aws_networkfirewall_firewall_policy.example.arn
  vpc_id              = aws_vpc.example.id
  subnet_mapping {
    subnet_id = aws_subnet.example.id
  }

  tags = {
    Tag1 = "Value1"
    Tag2 = "Value2"
  }

  timeouts {
     create = "35m"
     update = "40m"
     delete = "45m"
  }
}

Relations

Closes #34888

References

Output from Acceptance Testing

% make testacc TESTS=TestAccNetworkFirewallFirewall_ PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallFirewall_'  -timeout 360m
=== RUN   TestAccNetworkFirewallFirewall_basic
=== PAUSE TestAccNetworkFirewallFirewall_basic
=== RUN   TestAccNetworkFirewallFirewall_dualstackSubnet
=== PAUSE TestAccNetworkFirewallFirewall_dualstackSubnet
=== RUN   TestAccNetworkFirewallFirewall_description
=== PAUSE TestAccNetworkFirewallFirewall_description
=== RUN   TestAccNetworkFirewallFirewall_deleteProtection
=== PAUSE TestAccNetworkFirewallFirewall_deleteProtection
=== RUN   TestAccNetworkFirewallFirewall_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallFirewall_encryptionConfiguration
=== RUN   TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet
=== PAUSE TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet
=== RUN   TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets
=== PAUSE TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets
=== RUN   TestAccNetworkFirewallFirewall_tags
=== PAUSE TestAccNetworkFirewallFirewall_tags
=== RUN   TestAccNetworkFirewallFirewall_timeout
=== PAUSE TestAccNetworkFirewallFirewall_timeout
=== RUN   TestAccNetworkFirewallFirewall_disappears
=== PAUSE TestAccNetworkFirewallFirewall_disappears
=== CONT  TestAccNetworkFirewallFirewall_basic
=== CONT  TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet
=== CONT  TestAccNetworkFirewallFirewall_deleteProtection
=== CONT  TestAccNetworkFirewallFirewall_timeout
=== CONT  TestAccNetworkFirewallFirewall_encryptionConfiguration
=== CONT  TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets
=== CONT  TestAccNetworkFirewallFirewall_disappears
=== CONT  TestAccNetworkFirewallFirewall_tags
=== CONT  TestAccNetworkFirewallFirewall_description
=== CONT  TestAccNetworkFirewallFirewall_dualstackSubnet
--- PASS: TestAccNetworkFirewallFirewall_basic (1565.27s)
--- PASS: TestAccNetworkFirewallFirewall_disappears (1594.96s)
--- PASS: TestAccNetworkFirewallFirewall_dualstackSubnet (1596.85s)
--- PASS: TestAccNetworkFirewallFirewall_timeout (1598.73s)
--- PASS: TestAccNetworkFirewallFirewall_encryptionConfiguration (1625.55s)
--- PASS: TestAccNetworkFirewallFirewall_tags (1626.76s)
--- PASS: TestAccNetworkFirewallFirewall_deleteProtection (1656.03s)
--- PASS: TestAccNetworkFirewallFirewall_description (1656.11s)
--- PASS: TestAccNetworkFirewallFirewall_SubnetMappings_updateMultipleSubnets (3258.00s)
--- PASS: TestAccNetworkFirewallFirewall_SubnetMappings_updateSubnet (3294.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	3298.045s

% make testacc TESTS=TestAccNetworkFirewallFirewall_timeout PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallFirewall_timeout'  -timeout 360m
=== RUN   TestAccNetworkFirewallFirewall_timeout
=== PAUSE TestAccNetworkFirewallFirewall_timeout
=== CONT  TestAccNetworkFirewallFirewall_timeout
--- PASS: TestAccNetworkFirewallFirewall_timeout (1590.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	1593.850s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

make testacc TESTARGS="-run=TestAccNetworkFirewallFirewall_basic" PKG=networkfirewall                                 2 ↵
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20  -run=TestAccNetworkFirewallFirewall_basic -timeout 360m
=== RUN   TestAccNetworkFirewallFirewall_basic
=== PAUSE TestAccNetworkFirewallFirewall_basic
=== CONT  TestAccNetworkFirewallFirewall_basic
--- PASS: TestAccNetworkFirewallFirewall_basic (1668.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	1672.152s

[johnsonaj]

@alexknez thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.