Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_fis_experiment_template: Add all supported action targets #35300

Conversation

ebarros29
Copy link

Description

Add all remaining action targets supported by AWS FIS service:

  • Auto Scaling groups – Amazon EC2 Auto Scaling groups
  • Buckets – Amazon S3 buckets
  • Encrypted global tables – Amazon DynamoDB; global tables encrypted with a customer managed key
  • ReplicationGroups – ElastiCache Redis Replication Groups
  • TransitGateways – Transit gateways

Relations

Closes #35299

References

AWS FIS - Action targets

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccFISExperimentTemplate_basic" PKG=fis
TF_ACC=1 go test ./internal/service/fis/... -v -count 1 -parallel 20  -run=TestAccFISExperimentTemplate_basic -timeout 360m
=== RUN   TestAccFISExperimentTemplate_basic
=== PAUSE TestAccFISExperimentTemplate_basic
=== CONT  TestAccFISExperimentTemplate_basic
--- PASS: TestAccFISExperimentTemplate_basic (35.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fis        38.430s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jan 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 14, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/fis Issues and PRs that pertain to the fis service. labels Jan 14, 2024
@ebarros29 ebarros29 marked this pull request as ready for review January 14, 2024 05:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ebarros29 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 16, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@ebarros29 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d887a4c into hashicorp:main Jan 24, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 24, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fis Issues and PRs that pertain to the fis service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for all AWS FIS Action targets
4 participants