Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_fis_experiment_template: Add all supported action targets #35300

Merged
merged 3 commits into from
Jan 24, 2024
Merged

r/aws_fis_experiment_template: Add all supported action targets #35300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41c31b6
r/aws_fis_experiment_template: Add all supported action targets
Jan 14, 2024
a0de48e
docs: update CHANGELOG
Jan 14, 2024
8f986b0
fix: change array name for a name more suitable
Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/35300.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_fis_experiment_template: Add support for `AutoScalingGroups`, `Buckets`, `ReplicationGroups`, `Tables` and `TransitGateways` to `action.*.target`
```
9 changes: 7 additions & 2 deletions internal/service/fis/experiment_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,22 +983,27 @@ func validExperimentTemplateStopConditionSource() schema.SchemaValidateFunc {

func validExperimentTemplateActionTargetKey() schema.SchemaValidateFunc {
// See https://docs.aws.amazon.com/fis/latest/userguide/actions.html#action-targets
allowedStopConditionSources := []string{
allowedActionTargets := []string{
"AutoScalingGroups",
"Buckets",
"Cluster",
"Clusters",
"DBInstances",
"Instances",
"Nodegroups",
"Pods",
"ReplicationGroups",
"Roles",
"SpotInstances",
"Subnets",
"Tables",
"Tasks",
"TransitGateways",
"Volumes",
}

return validation.All(
validation.StringLenBetween(0, 64),
validation.StringInSlice(allowedStopConditionSources, false),
validation.StringInSlice(allowedActionTargets, false),
)
}
2 changes: 1 addition & 1 deletion website/docs/r/fis_experiment_template.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ For a list of parameters supported by each action, see [AWS FIS actions referenc

#### `target` (`action.*.target`)

* `key` - (Required) Target type. Valid values are `Cluster` (EKS Cluster), `Clusters` (ECS Clusters), `DBInstances` (RDS DB Instances), `Instances` (EC2 Instances), `Nodegroups` (EKS Node groups), `Roles` (IAM Roles), `SpotInstances` (EC2 Spot Instances), `Subnets` (VPC Subnets), `Volumes` (EBS Volumes) , `Pods` (EKS Pods), `Tasks` (ECS Tasks). See the [documentation](https://docs.aws.amazon.com/fis/latest/userguide/actions.html#action-targets) for more details.
* `key` - (Required) Target type. Valid values are `AutoScalingGroups` (EC2 Auto Scaling groups), `Buckets` (S3 Buckets), `Cluster` (EKS Cluster), `Clusters` (ECS Clusters), `DBInstances` (RDS DB Instances), `Instances` (EC2 Instances), `Nodegroups` (EKS Node groups), `Pods` (EKS Pods), `ReplicationGroups`(ElastiCache Redis Replication Groups), `Roles` (IAM Roles), `SpotInstances` (EC2 Spot Instances), `Subnets` (VPC Subnets), `Tables` (DynamoDB encrypted global tables), `Tasks` (ECS Tasks), `TransitGateways` (Transit gateways), `Volumes` (EBS Volumes). See the [documentation](https://docs.aws.amazon.com/fis/latest/userguide/actions.html#action-targets) for more details.
* `value` - (Required) Target name, referencing a corresponding target.

### `stop_condition`
Expand Down
Loading