Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_rds_cluster: add domain and domain_iam_role_name to rds_cluster #35753

Merged
merged 8 commits into from
Feb 12, 2024
Merged

r/aws_rds_cluster: add domain and domain_iam_role_name to rds_cluster #35753

merged 8 commits into from
Feb 12, 2024

Conversation

gungoren
Copy link
Contributor

@gungoren gungoren commented Feb 10, 2024

Description

add managed AD settings for RDS Cluster

Relations

Closes #15844.
Closes #12230.
Closes #32971.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSCluster_domain PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_domain'  -timeout 360m
=== RUN   TestAccRDSCluster_domain
=== PAUSE TestAccRDSCluster_domain
=== CONT  TestAccRDSCluster_domain
--- PASS: TestAccRDSCluster_domain (2167.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2173.780s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. labels Feb 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 10, 2024
@gungoren gungoren changed the title add domain and domain_iam_role_name to rds_cluster r/aws_rds_cluster: add domain and domain_iam_role_name to rds_cluster Feb 10, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 11, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2024
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCluster_domain\|TestAccRDSCluster_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_domain\|TestAccRDSCluster_basic -timeout 360m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_domain
=== PAUSE TestAccRDSCluster_domain
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_domain
--- PASS: TestAccRDSCluster_basic (155.35s)
--- PASS: TestAccRDSCluster_domain (2242.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2255.383s

@ewbankkit
Copy link
Contributor

@gungoren Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit af4efa6 into hashicorp:main Feb 12, 2024
53 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 12, 2024
@gungoren gungoren deleted the f-aws_rds_cluster-add-kerberos-domain-auth branch February 12, 2024 15:07
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants