-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: aws_redshift_data_share_consumer_association
#35771
Conversation
…D and ACTIVE The AUTHORIZED status should be present immediately following the AuthorizeDataShare API call. The ACTIVE status should be present following an AssociateDataShareConsumer API call, and therefore should not fall through to a NotFound error and trigger re-creation of the resource.
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
This resource will allow practitioners to manage Redshift data share consumer associations via Terraform.
7d50dbb
to
3ca109e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftDataShareConsumerAssociation_' PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run=TestAccRedshiftDataShareConsumerAssociation_ -timeout 360m
=== RUN TestAccRedshiftDataShareConsumerAssociation_basic
=== PAUSE TestAccRedshiftDataShareConsumerAssociation_basic
=== RUN TestAccRedshiftDataShareConsumerAssociation_disappears
=== PAUSE TestAccRedshiftDataShareConsumerAssociation_disappears
=== RUN TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount
=== PAUSE TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount
=== CONT TestAccRedshiftDataShareConsumerAssociation_basic
=== CONT TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount
=== CONT TestAccRedshiftDataShareConsumerAssociation_disappears
--- PASS: TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount (334.16s)
--- PASS: TestAccRedshiftDataShareConsumerAssociation_basic (354.32s)
--- PASS: TestAccRedshiftDataShareConsumerAssociation_disappears (371.05s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 381.954s
This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This resource will allow practitioners to manage Redshift data share consumer associations via Terraform.
Also fixes a bug in the
aws_redshift_data_share_authorization
data source that incorrectly handled anACTIVE
data share status, causing persistent differences and forced re-creation of the resource.Relations
Closes #33454
Relates #35703
References
Output from Acceptance Testing