r/aws_glue_catalog_database: add federated_database argument

[jar-b]

Description

The federated_database argument will allow practitioners to configure a glue database referencing a federated database entity outside the AWS Glue Data Catalog.

Also addresses a bug with aws_lakeformation_resource where the use_service_linked_role was being ignored when explicitly configured to false.

Relations

Closes #33453
Relates #35703
Relates #35771

References

• https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_DATASHARE.html
• https://docs.aws.amazon.com/lake-formation/latest/dg/setup-ds-perms.html

Output from Acceptance Testing

% make testacc PKG=glue TESTS=TestAccGlueCatalogDatabase_federatedDatabase
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogDatabase_federatedDatabase'  -timeout 360m
=== RUN   TestAccGlueCatalogDatabase_federatedDatabase
=== PAUSE TestAccGlueCatalogDatabase_federatedDatabase
=== CONT  TestAccGlueCatalogDatabase_federatedDatabase
--- PASS: TestAccGlueCatalogDatabase_federatedDatabase (316.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       323.887s

% make testacc PKG=glue TESTS=TestAccGlueCatalogDatabase_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogDatabase_'  -timeout 360m

--- PASS: TestAccGlueCatalogDatabase_disappears (12.55s)
--- PASS: TestAccGlueCatalogDatabase_targetDatabaseWithRegion (20.22s)
--- PASS: TestAccGlueCatalogDatabase_createTablePermission (22.82s)
--- PASS: TestAccGlueCatalogDatabase_targetDatabase (24.97s)
--- PASS: TestAccGlueCatalogDatabase_tags (30.04s)
--- PASS: TestAccGlueCatalogDatabase_full (30.95s)
--- PASS: TestAccGlueCatalogDatabase_federatedDatabase (347.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       354.919s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS='-run=TestAccGlueCatalogDatabase_' PKG=glue

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueCatalogDatabase_ -timeout 360m
--- PASS: TestAccGlueCatalogDatabase_disappears (13.64s)
--- PASS: TestAccGlueCatalogDatabase_targetDatabaseWithRegion (22.31s)
--- PASS: TestAccGlueCatalogDatabase_createTablePermission (23.57s)
--- PASS: TestAccGlueCatalogDatabase_targetDatabase (25.30s)
--- PASS: TestAccGlueCatalogDatabase_full (30.78s)
--- PASS: TestAccGlueCatalogDatabase_tags (30.78s)
--- PASS: TestAccGlueCatalogDatabase_federatedDatabase (347.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	354.503s

[github-actions]

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.