Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_mwaa_environment: add endpoint_management attribute #35961

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Feb 23, 2024

Description

  • Adds endpoint_management attribute
  • updates to AWS Go SDKv2

Relations

Closes #35339
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccMWAAEnvironment_' PKG=mwaa

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20  -run=TestAccMWAAEnvironment_ -timeout 360m
--- PASS: TestAccMWAAEnvironment_disappears (2836.84s)
--- PASS: TestAccMWAAEnvironment_basic (2897.43s)
--- PASS: TestAccMWAAEnvironment_full (2962.04s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (3357.28s)
--- PASS: TestAccMWAAEnvironment_log (3535.87s)
--- PASS: TestAccMWAAEnvironment_airflowOptions (4418.88s)
--- PASS: TestAccMWAAEnvironment_updateAirflowVersionMinor (6540.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	6548.094s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mwaa Issues and PRs that pertain to the mwaa service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 23, 2024
@johnsonaj johnsonaj added enhancement Requests to existing resources that expand the functionality or scope. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 23, 2024
@johnsonaj johnsonaj changed the title Fr/aws_mwaa_environment: add endpoint_management attribute r/aws_mwaa_environment: add endpoint_management attribute Feb 23, 2024
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Feb 23, 2024
@johnsonaj johnsonaj marked this pull request as ready for review February 23, 2024 22:04
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccMWAAEnvironment_' PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20  -run=TestAccMWAAEnvironment_ -timeout 360m

--- PASS: TestAccMWAAEnvironment_full (2682.70s)
--- PASS: TestAccMWAAEnvironment_basic (2988.47s)
--- PASS: TestAccMWAAEnvironment_disappears (3288.90s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (3635.29s)
--- PASS: TestAccMWAAEnvironment_log (4088.50s)
--- PASS: TestAccMWAAEnvironment_airflowOptions (4650.73s)
--- PASS: TestAccMWAAEnvironment_updateAirflowVersionMinor (5673.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       5680.313s

@johnsonaj johnsonaj merged commit 3fa0698 into main Feb 26, 2024
44 checks passed
@johnsonaj johnsonaj deleted the f-mwaa_environment_add_attribute branch February 26, 2024 17:05
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 26, 2024
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/mwaa Issues and PRs that pertain to the mwaa service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_mwaa_environment does not allow to chose Endpoint management creation
2 participants