Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: modification of cache_usage_limits (ecpu_per_second or data_storage maximum) in aws_elasticache_serverless_cache results in replacement #36317

Closed
mshahmoradi87 opened this issue Mar 12, 2024 · 8 comments · Fixed by #38269
Labels
bug Addresses a defect in current functionality. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@mshahmoradi87
Copy link

mshahmoradi87 commented Mar 12, 2024

Terraform Core Version

1.5.5

AWS Provider Version

5.40.0

Affected Resource(s)

aws_elasticache_serverless_cache

Expected Behavior

Change in limits should not destroy and recreate the cache, but just change the limit

Actual Behavior

if I change a limit, TF replaces the module, resulting in destroy and creation of the cache.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_elasticache_serverless_cache" "example" {
  engine = "redis"
  name = "example"
  
  cache_usage_limits {
    data_storage {
      maximum = 1
      unit = "GB"
    }

    ecpu_per_second {
      maximum = 1000
    }
  }

  daily_snapshot_time = "09:00"
  description = "Test Server"
  kms_key_id = aws_kms_key.test.arn
  major_engine_version = "7"
  snapshot_retention_limit = 1
  security_group_ids = [aws_security_group.test.id]
  subnet_ids = aws_subnet.test[*].id
}

Steps to Reproduce

  • create a redics cache and change one or both of the data_storage and ecpu and apply

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

@mshahmoradi87 mshahmoradi87 added the bug Addresses a defect in current functionality. label Mar 12, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/elasticache Issues and PRs that pertain to the elasticache service. label Mar 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 12, 2024
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 12, 2024
@emdneto
Copy link

emdneto commented Mar 14, 2024

I'm not sure if it's a bug, as this is defined here.

However, I agree that we don't need to replace the resource when changing the cache_usage_limits since AWS allows to change the limits with in-place updates.

Can anyone tell me if we really need RequiresReplace() for this case? If not, I can fix by removing this to allow update in-place when we set limits.

@mshahmoradi87
Copy link
Author

I'm not sure if it's a bug, as this is defined here.

However, I agree that we don't need to replace the resource when changing the cache_usage_limits since AWS allows to change the limits with in-place updates.

Can anyone tell me if we really need RequiresReplace() for this case? If not, I can fix by removing this to allow update in-place when we set limits.

Thanks for checking , it does not need to be replaced and in aws console you can change the limits.
however this has been added here , to fix the previous bug #35897 , and produced this new bug.

@mshahmoradi87
Copy link
Author

I'm not sure if it's a bug, as this is defined here.

However, I agree that we don't need to replace the resource when changing the cache_usage_limits since AWS allows to change the limits with in-place updates.

Can anyone tell me if we really need RequiresReplace() for this case? If not, I can fix by removing this to allow update in-place when we set limits.

@ewbankkit can you help to answer this question please.

@mshahmoradi87
Copy link
Author

@justinretzolk any chance this gets some attention please ?

Copy link

github-actions bot commented Jul 8, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.58.0 milestone Jul 8, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants