Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: modification of cache_usage_limits (ecpu_per_second or data_storage maximum) in aws_elasticache_serverless_cache results in InvalidParameterCombination: Serverless Cache modifications only support modifying one field per request. #35897

Closed
mshahmoradi87 opened this issue Feb 20, 2024 · 11 comments · Fixed by #35927
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@mshahmoradi87
Copy link

mshahmoradi87 commented Feb 20, 2024

Terraform Core Version

1.3.7

AWS Provider Version

5.37.0

Affected Resource(s)

  • aws_elasticache_serverless_cache

Expected Behavior

Modification of cache usage limits should be possible, in aws console modifing both limits of storage and ecpu at the same time works.

In the module no modification is possible.

Actual Behavior

plan:

          ~ ecpu_per_second {
              ~ maximum = 1000 -> 2000
            }

result:
InvalidParameterCombination: Serverless Cache modifications only support modifying one field per request.

plan:

          ~ data_storage {
              ~ maximum = 1 -> 2
                # (1 unchanged attribute hidden)
            }

result:
InvalidParameterCombination: Serverless Cache modifications only support modifying one field per request.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_elasticache_serverless_cache" "example" {
engine = "redis"
name = "example"
cache_usage_limits {
data_storage {
maximum = 1
unit = "GB"
}
ecpu_per_second {
maximum = 1000
}
}
daily_snapshot_time = "09:00"
description = "Test Server"
kms_key_id = aws_kms_key.test.arn
major_engine_version = "7"
snapshot_retention_limit = 1
security_group_ids = [aws_security_group.test.id]
subnet_ids = aws_subnet.test[*].id
}

Steps to Reproduce

  • create a redis_serverless_module
  • try to define or change cache_usage_limits

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@mshahmoradi87 mshahmoradi87 added the bug Addresses a defect in current functionality. label Feb 20, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/elasticache Issues and PRs that pertain to the elasticache service. label Feb 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 20, 2024
@mshahmoradi87
Copy link
Author

@meetreks please have a look if you have time, thanks in advance.

@zenzedoon
Copy link

The ecpu must be 0 ( for unlimited) or between 1000 and 15000000.

@mshahmoradi87
Copy link
Author

I see a related issue trigged by @justinretzolk

@rmmathik
Copy link

I will have a look and fix it if possible.

@meetreks
Copy link
Contributor

Was able to recreate the issue, let me fix it later today..

@meetreks
Copy link
Contributor

I fixed the issue highlighted for updating data_storage block - https://github.com/meetreks/terraform-provider-aws/pull/new/b-aws_elasticache_serverless_cache

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Feb 26, 2024
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 6, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@mshahmoradi87
Copy link
Author

@meetreks I have just tried the fix with v5.40.0, now plan works, but if I modify a limit, it results in module replacement,

so it destroyed the cache and recreated it.

@mshahmoradi87
Copy link
Author

#36317

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants