-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for 35897 #35927
Fix for 35897 #35927
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@justinretzolk yes it would. |
@justinretzolk any idea when this will be merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheServerlessCache_' PKG=elasticache ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 3 -run=TestAccElastiCacheServerlessCache_ -timeout 360m
=== RUN TestAccElastiCacheServerlessCache_basic
=== PAUSE TestAccElastiCacheServerlessCache_basic
=== RUN TestAccElastiCacheServerlessCache_basicRedis
=== PAUSE TestAccElastiCacheServerlessCache_basicRedis
=== RUN TestAccElastiCacheServerlessCache_full
=== PAUSE TestAccElastiCacheServerlessCache_full
=== RUN TestAccElastiCacheServerlessCache_fullRedis
=== PAUSE TestAccElastiCacheServerlessCache_fullRedis
=== RUN TestAccElastiCacheServerlessCache_update
=== PAUSE TestAccElastiCacheServerlessCache_update
=== RUN TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== RUN TestAccElastiCacheServerlessCache_disappears
=== PAUSE TestAccElastiCacheServerlessCache_disappears
=== RUN TestAccElastiCacheServerlessCache_tags
=== PAUSE TestAccElastiCacheServerlessCache_tags
=== CONT TestAccElastiCacheServerlessCache_basic
=== CONT TestAccElastiCacheServerlessCache_updatesc
=== CONT TestAccElastiCacheServerlessCache_fullRedis
--- PASS: TestAccElastiCacheServerlessCache_basic (385.48s)
=== CONT TestAccElastiCacheServerlessCache_tags
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (422.55s)
=== CONT TestAccElastiCacheServerlessCache_disappears
--- PASS: TestAccElastiCacheServerlessCache_updatesc (687.23s)
=== CONT TestAccElastiCacheServerlessCache_update
--- PASS: TestAccElastiCacheServerlessCache_disappears (284.89s)
=== CONT TestAccElastiCacheServerlessCache_full
--- PASS: TestAccElastiCacheServerlessCache_tags (453.47s)
=== CONT TestAccElastiCacheServerlessCache_basicRedis
--- PASS: TestAccElastiCacheServerlessCache_full (407.71s)
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (298.81s)
--- PASS: TestAccElastiCacheServerlessCache_update (457.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 1151.825s
@meetreks Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This change is for fixing the issue related to #35897 . The issue arises due to cache usage limits updates were not being handled properly and hence had to fix it.
Relations
Closes #35897
Closes #35660
References
Output from Acceptance Testing