Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 35897 #35927

Merged
Merged

Conversation

meetreks
Copy link
Contributor

@meetreks meetreks commented Feb 21, 2024

Description

This change is for fixing the issue related to #35897 . The issue arises due to cache usage limits updates were not being handled properly and hence had to fix it.

Relations

Closes #35897
Closes #35660

References

Output from Acceptance Testing

[ec2-user@ip-172-31-29-38 terraform-provider-aws]$ make testacc PKG=elasticache TESTS=TestAccElastiCacheServerlessCache_update
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheServerlessCache_update'  -timeout 360m
=== RUN   TestAccElastiCacheServerlessCache_update
=== PAUSE TestAccElastiCacheServerlessCache_update
=== CONT  TestAccElastiCacheServerlessCache_update
--- PASS: TestAccElastiCacheServerlessCache_update (350.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        350.206s
[ec2-user@ip-172-31-29-38 terraform-provider-aws]$ make testacc PKG=elasticache TESTS=TestAccElastiCacheServerlessCache_updatesc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheServerlessCache_updatesc'  -timeout 360m
=== RUN   TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== CONT  TestAccElastiCacheServerlessCache_updatesc
--- PASS: TestAccElastiCacheServerlessCache_updatesc (730.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        730.958s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. labels Feb 21, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Feb 21, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 26, 2024
@justinretzolk
Copy link
Member

Hey @meetreks 👋 Thank you for another contribution! I was looking over the related issue and saw #35660 mentioned, but couldn't quite tell -- would this PR close that one as well?

@meetreks
Copy link
Contributor Author

@justinretzolk yes it would.

@mshahmoradi87
Copy link

@justinretzolk any idea when this will be merged ?

@ewbankkit ewbankkit self-assigned this Mar 5, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 5, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheServerlessCache_' PKG=elasticache ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 3  -run=TestAccElastiCacheServerlessCache_ -timeout 360m
=== RUN   TestAccElastiCacheServerlessCache_basic
=== PAUSE TestAccElastiCacheServerlessCache_basic
=== RUN   TestAccElastiCacheServerlessCache_basicRedis
=== PAUSE TestAccElastiCacheServerlessCache_basicRedis
=== RUN   TestAccElastiCacheServerlessCache_full
=== PAUSE TestAccElastiCacheServerlessCache_full
=== RUN   TestAccElastiCacheServerlessCache_fullRedis
=== PAUSE TestAccElastiCacheServerlessCache_fullRedis
=== RUN   TestAccElastiCacheServerlessCache_update
=== PAUSE TestAccElastiCacheServerlessCache_update
=== RUN   TestAccElastiCacheServerlessCache_updatesc
=== PAUSE TestAccElastiCacheServerlessCache_updatesc
=== RUN   TestAccElastiCacheServerlessCache_disappears
=== PAUSE TestAccElastiCacheServerlessCache_disappears
=== RUN   TestAccElastiCacheServerlessCache_tags
=== PAUSE TestAccElastiCacheServerlessCache_tags
=== CONT  TestAccElastiCacheServerlessCache_basic
=== CONT  TestAccElastiCacheServerlessCache_updatesc
=== CONT  TestAccElastiCacheServerlessCache_fullRedis
--- PASS: TestAccElastiCacheServerlessCache_basic (385.48s)
=== CONT  TestAccElastiCacheServerlessCache_tags
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (422.55s)
=== CONT  TestAccElastiCacheServerlessCache_disappears
--- PASS: TestAccElastiCacheServerlessCache_updatesc (687.23s)
=== CONT  TestAccElastiCacheServerlessCache_update
--- PASS: TestAccElastiCacheServerlessCache_disappears (284.89s)
=== CONT  TestAccElastiCacheServerlessCache_full
--- PASS: TestAccElastiCacheServerlessCache_tags (453.47s)
=== CONT  TestAccElastiCacheServerlessCache_basicRedis
--- PASS: TestAccElastiCacheServerlessCache_full (407.71s)
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (298.81s)
--- PASS: TestAccElastiCacheServerlessCache_update (457.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	1151.825s

@ewbankkit
Copy link
Contributor

@meetreks Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit be3dae1 into hashicorp:main Mar 6, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 6, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/elasticache Issues and PRs that pertain to the elasticache service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants