Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_dms_replication_config, aws_dms_replication_task: suppress differences on task settings #36936

Merged
merged 18 commits into from
Apr 17, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Apr 16, 2024

Description

When a partial task settings JSON document is passed, the resource would show a perpetual diff.

Also suppresses differences for read-only fields in task settings and allows not setting task settings on aws_dms_replication_task.

Relations

Closes #36598
Closes #21512
Closes #19021
Closes #35812

References

Output from Acceptance Testing

Commercial Partition

% make testacc PKG=dms TESTS=TestAccDMSReplicationConfig_

--- PASS: TestAccDMSReplicationConfig_settings_LoggingValidation (17.94s)
--- PASS: TestAccDMSReplicationConfig_disappears (102.63s)
--- PASS: TestAccDMSReplicationConfig_basic (0.00s)
    --- PASS: TestAccDMSReplicationConfig_basic/cdc (108.38s)
    --- PASS: TestAccDMSReplicationConfig_basic/full-load-and-cdc (108.43s)
    --- PASS: TestAccDMSReplicationConfig_basic/full-load (113.34s)
--- PASS: TestAccDMSReplicationConfig_settings_StreamBuffer (113.45s)
--- PASS: TestAccDMSReplicationConfig_settings_LogComponents (113.73s)
--- PASS: TestAccDMSReplicationConfig_update (131.42s)
--- PASS: TestAccDMSReplicationConfig_settings_EnableLogging (150.97s)
--- PASS: TestAccDMSReplicationConfig_tags (151.96s)
--- PASS: TestAccDMSReplicationConfig_startReplication (3047.40s)
% make testacc PKG=dms TESTS=TestAccDMSReplicationTask_

--- PASS: TestAccDMSReplicationTask_settings_LoggingValidation (6.70s)
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (1013.33s)
--- PASS: TestAccDMSReplicationTask_settings_StreamBuffer (1115.40s)
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (1135.50s)
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (1217.99s)
--- PASS: TestAccDMSReplicationTask_disappears (1236.11s)
--- PASS: TestAccDMSReplicationTask_settings_EnableLogging (1333.38s)
--- PASS: TestAccDMSReplicationTask_basic (0.00s)
    --- PASS: TestAccDMSReplicationTask_basic/full-load (1197.08s)
    --- PASS: TestAccDMSReplicationTask_basic/full-load-and-cdc (1217.02s)
    --- PASS: TestAccDMSReplicationTask_basic/cdc (1340.02s)
--- PASS: TestAccDMSReplicationTask_updateSettingsAndMappings (1459.93s)
--- PASS: TestAccDMSReplicationTask_move (1578.81s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1615.81s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1714.12s)

GovCloud Partition

% make testacc PKG=dms TESTS=TestAccDMSReplicationConfig_

--- SKIP: TestAccDMSReplicationConfig_settings_LogComponents (106.04s)
--- SKIP: TestAccDMSReplicationConfig_tags (106.27s)
--- SKIP: TestAccDMSReplicationConfig_disappears (106.28s)
--- SKIP: TestAccDMSReplicationConfig_settings_StreamBuffer (115.65s)
--- SKIP: TestAccDMSReplicationConfig_settings_EnableLogging (115.74s)
--- SKIP: TestAccDMSReplicationConfig_update (116.02s)
--- PASS: TestAccDMSReplicationConfig_basic (0.00s)
    --- SKIP: TestAccDMSReplicationConfig_basic/full-load-and-cdc (115.68s)
    --- SKIP: TestAccDMSReplicationConfig_basic/cdc (116.01s)
    --- SKIP: TestAccDMSReplicationConfig_basic/full-load (116.02s)
--- SKIP: TestAccDMSReplicationConfig_startReplication (1264.65s)
% make testacc PKG=dms TESTS=TestAccDMSReplicationTask_

--- PASS: TestAccDMSReplicationTask_settings_LoggingValidation (2.31s)
--- PASS: TestAccDMSReplicationTask_basic (0.00s)
    --- PASS: TestAccDMSReplicationTask_basic/full-load-and-cdc (1030.88s)
    --- PASS: TestAccDMSReplicationTask_basic/cdc (1030.88s)
    --- PASS: TestAccDMSReplicationTask_basic/full-load (1030.89s)
--- PASS: TestAccDMSReplicationTask_disappears (1036.88s)
--- FAIL: TestAccDMSReplicationTask_settings_EnableLogging (1042.15s)
--- PASS: TestAccDMSReplicationTask_settings_StreamBuffer (1049.78s)
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (1050.21s)
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (1068.61s)
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (1068.68s)
--- PASS: TestAccDMSReplicationTask_updateSettingsAndMappings (1308.25s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1324.90s)
--- PASS: TestAccDMSReplicationTask_move (1410.57s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1443.34s)

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dms Issues and PRs that pertain to the dms service. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 16, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Apr 16, 2024
@gdavison gdavison force-pushed the b-dms-replication-task-settings branch from 1911d1d to ad31404 Compare April 16, 2024 23:40
@gdavison gdavison marked this pull request as ready for review April 16, 2024 23:41
@jar-b jar-b self-requested a review April 17, 2024 14:29
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b
Copy link
Member

jar-b commented Apr 17, 2024

Needs a changelog.

@gdavison gdavison merged commit 1b41728 into main Apr 17, 2024
37 checks passed
@gdavison gdavison deleted the b-dms-replication-task-settings branch April 17, 2024 18:40
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 17, 2024
github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants