Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Specify IAM role(s) for RDS Cluster #382

Closed
hashibot opened this issue Jun 13, 2017 · 1 comment · Fixed by #1258
Closed

Feature Request: Specify IAM role(s) for RDS Cluster #382

hashibot opened this issue Jun 13, 2017 · 1 comment · Fixed by #1258
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@hashibot
Copy link

This issue was originally opened by @thejaywhy as hashicorp/terraform#10166. It was migrated here as part of the provider split. The original body of the issue is below.


AWS Aurora recently added supports adding roles to the RDS cluster. This can be used to integrate Aurora with other AWS services, such as S3 or Lambda.

For details on this please see: http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Aurora.Authorizing.AWSServices.html

It would be nice to have the ability to add IAM roles to an an aws_rds_cluster in much the same way as the aws_redshift_cluster resource's iam_roles attribute.

@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 13, 2017
stack72 added a commit that referenced this issue Jul 10, 2017
Fixes: #382

We store the state of the role that was added so that we can understand
if the status of the role is `invalid` and thus an error has occurred

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_updateIamRoles'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSCluster_updateIamRoles -timeout 120m
=== RUN   TestAccAWSRDSCluster_updateIamRoles
--- PASS: TestAccAWSRDSCluster_updateIamRoles (190.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	190.769s
```
stack72 added a commit to stack72/terraform-provider-aws that referenced this issue Jul 27, 2017
Rework of hashicorp#1093
Fixes: hashicorp#382

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_updateIamRoles'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSCluster_updateIamRoles -timeout 120m
=== RUN   TestAccAWSRDSCluster_updateIamRoles
--- PASS: TestAccAWSRDSCluster_updateIamRoles (170.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	170.374s
```
jocgir pushed a commit to coveooss/terraform-provider-aws that referenced this issue Aug 28, 2017
Rework of hashicorp#1093
Fixes: hashicorp#382

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_updateIamRoles'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSCluster_updateIamRoles -timeout 120m
=== RUN   TestAccAWSRDSCluster_updateIamRoles
--- PASS: TestAccAWSRDSCluster_updateIamRoles (170.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	170.374s
```
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
2 participants