[Enhancement]: aws_amplify_domain_association certificate_settings AMPLIFY_MANAGED should be default

[rsi-mrobinson]

Description

the newly added (>=5.57.0) certificate_settings attribute should default to AMPLIFY_MANAGED rather than null. Existing resources appear to result in plans where the certificate settings are being removed, despite amplify managed domains being the default up to this point. The new certificate setting block should respect this an only be required to override the default settings.

Affected Resource(s) and/or Data Source(s)

aws_amplify_domain_association

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[justinretzolk]

Hey @rsi-mrobinson 👋 Thank you for taking the time to raise this! To make sure I understand -- you're saying that if you update the version and make no other configuration changes, resources are being replaced on the next apply?

[rsi-mrobinson]

That's correct, if you upgrade to 5.57 or above without making changes to this resource, the plan shows a change to remove the default amplify managed dns

[aayushsss1]

Hey @justinretzolk @rsi-mrobinson I can take this issue up, just to be clear the only change would be to add
Default : "AMPLIFY_MANAGED" here right?

terraform-provider-aws/internal/service/amplify/domain_association.go

Lines 61 to 67 in c3b9b48

	},
	names.AttrType: {
	Type: schema.TypeString,
	Required: true,
	ValidateDiagFunc: enum.Validate[types.CertificateType](),
	},
	"custom_certificate_arn": {

[rsi-mrobinson]

That's what I'm thinking

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.