Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AMPLIFY_MANAGED as the default value for aws_amplify_domain_association.certificate_settings.type #38410

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aayushsss1
Copy link

Description

Added AMPLIFY_MANAGED as the default value for the type attribute. Without the default value, the resource will be replaced on the next plan/apply.

The issue occurs when users update the provider version to 5.57 or above, without making any changes to the resource.

Relations

Closes #38387

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@aayushsss1 aayushsss1 requested a review from a team as a code owner July 18, 2024 13:51
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added service/amplify Issues and PRs that pertain to the amplify service. size/XS Managed by automation to categorize the size of a PR. labels Jul 18, 2024
Signed-off-by: aayushsss1 <aayushsubramaniam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/amplify Issues and PRs that pertain to the amplify service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_amplify_domain_association certificate_settings AMPLIFY_MANAGED should be default
1 participant