docdbelastic: Support backup_retention_period

[ayumitamai97]

Description

• Support backup_retention_period for DocumentDB Elastic Cluster
• Update the day of the week format for the acceptance test data
  • The first character of the day of the week should be upper case e.g. Mon
  • The acceptance tests don't pass without this change

Relations

N/A

References

• backup_retention_period
  • API specification https://docs.aws.amazon.com/documentdb/latest/developerguide/API_elastic_CreateCluster.html
  • The number should be between 1 and 35 https://docs.aws.amazon.com/documentdb/latest/developerguide/backup_restore.html
• Day of the week format
  • https://docs.aws.amazon.com/documentdb/latest/developerguide/db-cluster-modify.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccDocDBElasticCluster_update PKG=docdbelastic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/docdbelastic/... -v -count 1 -parallel 20 -run='TestAccDocDBElasticCluster_update'  -timeout 360m
=== RUN   TestAccDocDBElasticCluster_update
=== PAUSE TestAccDocDBElasticCluster_update
=== CONT  TestAccDocDBElasticCluster_update
--- PASS: TestAccDocDBElasticCluster_update (3854.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/docdbelastic       3858.935s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[github-actions]

Welcome @ayumitamai97 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ayumitamai97]

Thank you for prioritization, I'll resolve conflicts soon.

[johnsonaj]

Thank you for prioritization, I'll resolve conflicts soon.

@ayumitamai97 Thanks for the followup! I am in the process of resolving the conflicts and will push updates shortly

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS="-run=TestAccDocDBElasticCluster_basic\|TestAccDocDBElasticCluster_update\|TestAccDocDBElasticCluster_disappears" PKG=docdbelastic

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/docdbelastic/... -v -count 1 -parallel 20  -run=TestAccDocDBElasticCluster_basic\|TestAccDocDBElasticCluster_update\|TestAccDocDBElasticCluster_disappears -timeout 360m
--- PASS: TestAccDocDBElasticCluster_basic (2430.48s)
--- PASS: TestAccDocDBElasticCluster_disappears (2484.99s)
--- PASS: TestAccDocDBElasticCluster_update (4160.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdbelastic	4166.958s

[johnsonaj]

@ayumitamai97 thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!