Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_docdbelastic_cluster: Add backup_retention_period and pr… #38952

Conversation

trutled3
Copy link
Contributor

@trutled3 trutled3 commented Aug 20, 2024

Description

This adds the backupRetentionPeriod and preferredBackupWindow capabilities from the CreateCluster API for AWS DocumentDB Elastic Clusters.

Relations

Closes #38940

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDocDBElasticCluster_basic PKG=dockdbelastic
=== RUN   TestAccDocDBElasticCluster_basic
=== PAUSE TestAccDocDBElasticCluster_basic
=== CONT  TestAccDocDBElasticCluster_basic
--- PASS: TestAccDocDBElasticCluster_basic (3314.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/docdbelastic       3319.516s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. needs-triage Waiting for first response or review from a maintainer. labels Aug 20, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 21, 2024
@trutled3 trutled3 marked this pull request as ready for review August 21, 2024 18:22
@trutled3 trutled3 requested a review from a team as a code owner August 21, 2024 18:22
@johnsonaj
Copy link
Contributor

Hi @trutled3, thank you for the contribution! This enhancement was released in v5.66.0 with PR #38452. I'll go ahead and close this as a duplicate.

@johnsonaj johnsonaj closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_docdbelastic_cluster: add argument 'backup-retention-period' and 'preferred-backup-window'
3 participants