Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source for aws_kinesis_firehose_delivery_stream #3865

Closed
bacoboy opened this issue Mar 21, 2018 · 11 comments · Fixed by #18445
Closed

Data Source for aws_kinesis_firehose_delivery_stream #3865

bacoboy opened this issue Mar 21, 2018 · 11 comments · Fixed by #18445
Labels
new-data-source Introduces a new data source. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@bacoboy
Copy link

bacoboy commented Mar 21, 2018

It would be helpful to have a way to lookup an aws_kinesis_firehose_delivery_stream by name to get the ARN and other attributes. Usually Data Sources are used for this, but it seems to have been left out of the original implementation.

Side note: I'd argue that most new resources should probably have corresponding data sources made at time they are added to this provider. Just saying...

@bflad bflad added new-data-source Introduces a new data source. service/firehose Issues and PRs that pertain to the firehose service. labels Mar 21, 2018
@monkey-jeff
Copy link

I noticed this too

@bacoboy
Copy link
Author

bacoboy commented Nov 8, 2018

Coming up on EOY. No takers from some kind soul to implement? 😉

@bflad
Copy link
Contributor

bflad commented Nov 8, 2018

Hi @bacoboy 👋 It might be helpful to know what information you're looking to get out of the data source. The resource itself is very large.

@bacoboy
Copy link
Author

bacoboy commented Nov 8, 2018

At this point I'm just looking for a way to lookup the ARN from the name -- basically a terraform equivalent of the describe-delivery-stream cli.

Top of the list is getting the ARN, but I could also see useful things in a first pass like the role and status. I agree the rest is verbose, but at least knowing S3 is configured, or ES would be helpful in a first pass even if every last detail wasn't there.

@bacoboy
Copy link
Author

bacoboy commented Sep 6, 2019

Almost another year lapsed here. Anybody want to take a crack at this?

@bacoboy
Copy link
Author

bacoboy commented Mar 23, 2020

Happy 2 year anniversary to this issue! 🥈

@querry43
Copy link

I too need a way to lookup existing resources. Our common infrastructure is in one terraform and the apps themselves in another. I would like to reference the arn of a firehose from common infra in the app configs where cloudfront and waf are configured.

@theherk
Copy link
Contributor

theherk commented Mar 25, 2021

Happy 3rd anniversary. :) It looks like this will be pretty straight forward, so I'll make an attempt within the next few days.

@robotdan
Copy link

robotdan commented Sep 8, 2021

Is the AWS Terraform module still under development? It looks like a PR has been submitted. Do we just need someone to review and merge the PR?

ewbankkit pushed a commit that referenced this issue Sep 27, 2021
The goal is to simply allow referencing preexisting Delivery Streams.
This is a feature a few have sought. Fixes #3865.
@github-actions github-actions bot added this to the v3.61.0 milestone Sep 27, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants