-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting endpoint for EFS #3888
Comments
@bflad I have a branch with a commit to fix this enhancement. |
The provider configuration for the custom EFS endpoint will release with v1.22.0 of the AWS provider, middle of this week. |
This has been released in version 1.22.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including: * FIPS 140-2 compliant endpoints * AWS C2S and SC2S potential usage * AWS Snowball potential usage * Local testing solutions such as LocalStack * Rare incorrect default endpoint information provided by the AWS Go SDK This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints). Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency. References: * https://aws.amazon.com/compliance/fips/ * https://aws.amazon.com/federal/us-intelligence-community/ * https://aws.amazon.com/snowball/ * https://docs.aws.amazon.com/cli/latest/index.html * https://localstack.cloud/ * #7735 * #8007 * #7985 * #4967 * #4670 * #3941 * #3888 * #3608
Historically, we have treated endpoint customization as an optional enhancement when adding service clients to the provider. Over time, the necessity of service endpoint customization has changed including: * FIPS 140-2 compliant endpoints * AWS C2S and SC2S potential usage * AWS Snowball potential usage * Local testing solutions such as LocalStack * Rare incorrect default endpoint information provided by the AWS Go SDK This change enables all existing service clients to support endpoint customization and going forward we can include this support by default. If the AWS Go SDK provides a better customization method in the future or defines environment variable support, we can revisit this in the future. We may also choose to further optimize endpoint handling via new provider configurations (e.g. use all known FIPS 140-2 endpoints). Endpoint service naming is based on existing configuration. Where we do not have a prior configuration, we opt for using the AWS CLI service naming minus any hyphens. We also deprecate our own naming for `kinesis_analytics` and `r53` with `kinesisanalytics` and `route53` respectively for consistency. References: * https://aws.amazon.com/compliance/fips/ * https://aws.amazon.com/federal/us-intelligence-community/ * https://aws.amazon.com/snowball/ * https://docs.aws.amazon.com/cli/latest/index.html * https://localstack.cloud/ * hashicorp#7735 * hashicorp#8007 * hashicorp#7985 * hashicorp#4967 * hashicorp#4670 * hashicorp#3941 * hashicorp#3888 * hashicorp#3608
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Terraform Version
Terraform v0.11.5
Affected Resource(s)
Terraform Configuration Files
aws-provider.tf file
provider "aws" {
access_key = "access_key"
secret_key = "secret_key"
}
N/A
Debug Output
[jwahba@localhost rds-simple]$ sudo ./terraform apply
Error: provider.aws: endpoints.0: invalid or unknown key: efs
Panic Output
N/A
Expected Behavior
Terraform provider should allow users to set efs endpoint
Actual Behavior
Terraform provider doesn't allow users to set efs endpoint
Steps to Reproduce
1- Set aws-provider efs endpoint
2- Run ./terraform apply
Important Factoids
N/A
References
This is a similar bug to
https://github.com/terraform-providers/terraform-provider-aws/pull/2795/files
The text was updated successfully, but these errors were encountered: