Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_verifiedaccess_endpoint: fix crash when updating load_balancer_options.subnet_ids #39196

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 6, 2024

Description

Fixes an incorrect assertion of a set type to an []interface{}.

Relations

Closes #39186

Output from Acceptance Testing

% make testacc PKG=ec2 TESTS=TestAccVerifiedAccess_serial/Endpoint/basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccess_serial/Endpoint/basic'  -timeout 360m

--- PASS: TestAccVerifiedAccess_serial (0.59s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1115.35s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1278.48s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1289.64s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1371.40s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1451.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1458.259s

Copy link

github-actions bot commented Sep 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 6, 2024
…_options.subnet_ids`

```console
% make testacc PKG=ec2 TESTS=TestAccVerifiedAccess_serial/Endpoint/basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccess_serial/Endpoint/basic'  -timeout 360m

--- PASS: TestAccVerifiedAccess_serial (0.59s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1115.35s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1278.48s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1289.64s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1371.40s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1451.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1458.259s
```
@jar-b jar-b force-pushed the b-verifiedaccess_endpoint-crash branch from 32a32ad to c99227a Compare September 6, 2024 16:04
@jar-b jar-b added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Sep 6, 2024
@jar-b jar-b marked this pull request as ready for review September 6, 2024 16:04
@jar-b jar-b requested a review from a team as a code owner September 6, 2024 16:04
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Can we add an acceptance test case for this?

@jar-b
Copy link
Member Author

jar-b commented Sep 9, 2024

Test results after updating acceptance tests:

% make testacc PKG=ec2 TESTS=TestAccVerifiedAccess_serial/Endpoint ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVerifiedAccess_serial/Endpoint'  -timeout 360m

--- PASS: TestAccVerifiedAccess_serial (0.52s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1380.55s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1390.69s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1584.75s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1099.79s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1227.56s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_subnetIDs (1632.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        3019.479s

@jar-b jar-b merged commit bca2796 into main Sep 9, 2024
34 checks passed
@jar-b jar-b deleted the b-verifiedaccess_endpoint-crash branch September 9, 2024 13:45
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Verified access endpoint
2 participants