Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_verifiedaccess_endpoint: fix crash when updating load_balancer_options.subnet_ids #39196

Merged
merged 3 commits into from
Sep 9, 2024
Merged

r/aws_verifiedaccess_endpoint: fix crash when updating load_balancer_options.subnet_ids #39196

merged 3 commits into from
Sep 9, 2024

Commits on Sep 6, 2024

  1. r/aws_verifiedaccess_endpoint: fix crash when updating `load_balancer… 

    …_options.subnet_ids`

```console
% make testacc PKG=ec2 TESTS=TestAccVerifiedAccess_serial/Endpoint/basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVerifiedAccess_serial/Endpoint/basic'  -timeout 360m

--- PASS: TestAccVerifiedAccess_serial (0.59s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1115.35s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1278.48s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1289.64s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1371.40s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1451.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1458.259s
```
    @jar-b
    jar-b committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c99227a View commit details
    Browse the repository at this point in the history

  2. r/aws_verifiedaccess_endpoint(test): add subnet ID update test

    @jar-b
    jar-b committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e5d4c3c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. chore: make fix-constants

    @jar-b
    jar-b committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f9def71 View commit details
    Browse the repository at this point in the history