-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Snowflake destination buffering hint settings for aws_kinesis_firehose_delivery_stream #39214
feat: Add Snowflake destination buffering hint settings for aws_kinesis_firehose_delivery_stream #39214
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…is_firehose_delivery_stream
5c55ca3
to
0a60cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_snowflake' PKG=firehose ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/firehose/... -v -count 1 -parallel 3 -run=TestAccFirehoseDeliveryStream_snowflake -timeout 360m
=== RUN TestAccFirehoseDeliveryStream_snowflakeUpdates
=== PAUSE TestAccFirehoseDeliveryStream_snowflakeUpdates
=== CONT TestAccFirehoseDeliveryStream_snowflakeUpdates
--- PASS: TestAccFirehoseDeliveryStream_snowflakeUpdates (169.18s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/firehose 174.152s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add buffering hint settings for the Snowflake destination, specifically
snowflake_configuration.buffering_interval
andsnowflake_configuration.buffering_size
, for theaws_kinesis_firehose_delivery_stream
resource.Relations
Closes #38696
References
Referred to SnowflakeDestinationConfiguration for specs.
Output from Acceptance Testing