Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_quicksight_vpc_connection: Remove vpc_connection_id regex validator #39231

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 9, 2024

Description

Fixes v5.66.0 regression.
There is nor regular expression validator defined in the API documentation or the QuickSight console, so just removed from the code.

Relations

Closes #39228.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccQuickSightVPCConnection_' PKG=quicksight ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/quicksight/... -v -count 1 -parallel 3  -run=TestAccQuickSightVPCConnection_ -timeout 360m
=== RUN   TestAccQuickSightVPCConnection_basic
=== PAUSE TestAccQuickSightVPCConnection_basic
=== RUN   TestAccQuickSightVPCConnection_disappears
=== PAUSE TestAccQuickSightVPCConnection_disappears
=== RUN   TestAccQuickSightVPCConnection_tags
=== PAUSE TestAccQuickSightVPCConnection_tags
=== CONT  TestAccQuickSightVPCConnection_basic
=== CONT  TestAccQuickSightVPCConnection_tags
=== CONT  TestAccQuickSightVPCConnection_disappears
--- PASS: TestAccQuickSightVPCConnection_basic (139.70s)
--- PASS: TestAccQuickSightVPCConnection_disappears (139.71s)
--- PASS: TestAccQuickSightVPCConnection_tags (187.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	192.237s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	0.551s [no tests to run]

@ewbankkit ewbankkit requested a review from a team as a code owner September 9, 2024 18:05
Copy link

github-actions bot commented Sep 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 9, 2024
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Sep 9, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 4c74021 into main Sep 9, 2024
44 checks passed
@ewbankkit ewbankkit deleted the issue-39228 branch September 9, 2024 21:36
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 9, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_quicksight_vpc_connection ID validation rules are broken
2 participants