Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Add tags toaws_connect_instance resource #39402

Merged

Conversation

bruceharrison1984
Copy link
Contributor

@bruceharrison1984 bruceharrison1984 commented Sep 19, 2024

Description

This adds tag support to the already existing aws_connect_instance resource

Relations

Closes #38849

References

Output from Acceptance Testing

% make testacc TESTS=TestAccConnect_serial PKG=connect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnect_serial'  -timeout 360m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/Instance
=== RUN   TestAccConnect_serial/Instance/tags
--- PASS: TestAccConnect_serial (131.62s)
    --- PASS: TestAccConnect_serial/Instance (131.62s)
        --- PASS: TestAccConnect_serial/Instance/tags (131.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    137.401s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/connect Issues and PRs that pertain to the connect service. needs-triage Waiting for first response or review from a maintainer. labels Sep 19, 2024
@bruceharrison1984 bruceharrison1984 changed the title [enhancement] Add tags to Connect Instance resource [enhancement] Add tags toaws_connect_instance resource Sep 19, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Sep 19, 2024
@github-actions github-actions bot added the generators Relates to code generators. label Sep 19, 2024
@bruceharrison1984 bruceharrison1984 marked this pull request as ready for review September 19, 2024 19:13
@bruceharrison1984 bruceharrison1984 requested a review from a team as a code owner September 19, 2024 19:13
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 19, 2024
@ewbankkit ewbankkit self-assigned this Sep 19, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 19, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnect_serial/^Instance$$' PKG=connect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/^Instance$ -timeout 360m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/Instance
=== RUN   TestAccConnect_serial/Instance/basic
=== RUN   TestAccConnect_serial/Instance/directory
=== RUN   TestAccConnect_serial/Instance/saml
=== RUN   TestAccConnect_serial/Instance/dataSource_basic
=== RUN   TestAccConnect_serial/Instance/tags
--- PASS: TestAccConnect_serial (1201.34s)
    --- PASS: TestAccConnect_serial/Instance (1201.34s)
        --- PASS: TestAccConnect_serial/Instance/basic (97.21s)
        --- PASS: TestAccConnect_serial/Instance/directory (776.04s)
        --- PASS: TestAccConnect_serial/Instance/saml (93.41s)
        --- PASS: TestAccConnect_serial/Instance/dataSource_basic (118.27s)
        --- PASS: TestAccConnect_serial/Instance/tags (116.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	1206.325s

@ewbankkit
Copy link
Contributor

@bruceharrison1984 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 22d4406 into hashicorp:main Sep 20, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 20, 2024
@bruceharrison1984 bruceharrison1984 deleted the add-tags-to-connect-instance branch September 20, 2024 13:52
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Connect instance creation ignore default tags
2 participants