-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] Add tags
toaws_connect_instance
resource
#39402
[enhancement] Add tags
toaws_connect_instance
resource
#39402
Conversation
Community NoteVoting for Prioritization
For Submitters
|
tags
to Connect Instance resourcetags
toaws_connect_instance
resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccConnect_serial/^Instance$$' PKG=connect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccConnect_serial/^Instance$ -timeout 360m
=== RUN TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT TestAccConnect_serial
=== RUN TestAccConnect_serial/Instance
=== RUN TestAccConnect_serial/Instance/basic
=== RUN TestAccConnect_serial/Instance/directory
=== RUN TestAccConnect_serial/Instance/saml
=== RUN TestAccConnect_serial/Instance/dataSource_basic
=== RUN TestAccConnect_serial/Instance/tags
--- PASS: TestAccConnect_serial (1201.34s)
--- PASS: TestAccConnect_serial/Instance (1201.34s)
--- PASS: TestAccConnect_serial/Instance/basic (97.21s)
--- PASS: TestAccConnect_serial/Instance/directory (776.04s)
--- PASS: TestAccConnect_serial/Instance/saml (93.41s)
--- PASS: TestAccConnect_serial/Instance/dataSource_basic (118.27s)
--- PASS: TestAccConnect_serial/Instance/tags (116.41s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 1206.325s
@bruceharrison1984 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This adds
tag
support to the already existingaws_connect_instance
resourceRelations
Closes #38849
References
Output from Acceptance Testing