[Enhancement]: Add Valkey support to Elasticache resources

[jalaziz]

Description

AWS recently announced support for Valkey as an Elasticache engine.

Attempting to use valkey as an engine argument with the existing resources results in a validation error: expected engine to be one of ["redis"], got valkey.

Affected Resource(s) and/or Data Source(s)

• aws_elasticache_replication_group
• aws_elasticache_cluster
• aws_elasticache_serverless_cache

Potential Terraform Configuration

resource "aws_elasticache_replication_group" "this" {
  engine               = "valkey"
  ...
}

References

• Blog post

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[rtomadpg]

Would this be as simple adding valkey to the list of valid engine values, in: https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/elasticache/consts.go ?

Btw the elasticache API docs have not yet been updated: https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_CreateCacheCluster.html :

Engine
The name of the cache engine to be used for this cluster.

Valid values for this parameter are: memcached | redis

Type: String

Required: No

[jalaziz]

Would this be as simple adding valkey to the list of valid engine values, in: https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/elasticache/consts.go ?

I think it is a bit more involved as validation also needs to be updated: https://github.com/hashicorp/terraform-provider-aws/blob/main/internal%2Fservice%2Felasticache%2Freplication_group.go#L129

Btw the elasticache API docs have not yet been updated: https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_CreateCacheCluster.html :

Yes, the docs only seem to be partially updated.

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[h3ct0rjs]

I have tried to use the new value in version v5.76.0 and it says :

│ Error: expected engine to be one of ["memcached" "redis"], got valkey
│
│   with module.redis.aws_elasticache_cluster.this,
│   on redis-test.tf line 16, in resource "aws_elasticache_cluster" "this":
│   16:   engine                     = "valkey"

Is this officially rolled out ?

[johndoe1505707]

@h3ct0rjs Yes, it's rolled out.

AWS API provides valkey as aws_elasticache_replication_group, not as aws_elasticache_cluster.

[ithacasnowman]

Valkey clusters can be sized below 1 GB as per this AWS blog post. However, there is no way to use the current implementation to configure a Valkey cache with less than 1 GB, as far as I can tell, because under the data_strage block, unit must be GB and maximum/minimum must be between 1 and 5,000.

[h3ct0rjs]

I was able to test this out, it looks like is available now. 😃 . Thanks for the answer @johndoe1505707