[Enhancement]: Add tags support for aws_route53profiles_profile and aws_route53profiles_association

[ineednewpajamas]

Description

Add support for the tags argument for aws_route53profiles_profile and aws_route53profiles_association. Tags are supported in awscc and the sdk.

Affected Resource(s) and/or Data Source(s)

aws_route53profiles_profile
aws_route53profiles_association

Potential Terraform Configuration

resource "aws_route53profiles_profile" "dev" {
  name = "example"

  tags = {
    Environment = "dev"
  }
}

References

https://registry.terraform.io/providers/hashicorp/awscc/latest/docs/resources/route53profiles_profile
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/route53profiles#CreateProfileInput

Would you like to implement a fix?

No

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[jeremychauvet]

Hello @ineednewpajamas 👋🏼
Reviewing resource parameters, I've seen there's a tags_all attribute available.
Is it possible that this is matching what you're looking for?

[ineednewpajamas]

tags_all which is just exported, and default_tags which is what feeds tags_all is not what I'm looking for. We need the ability to define specific tags for the resources.

[jeremychauvet]

Hello again @ineednewpajamas!
I've opened a PR on the provider to improve the documentation, thank you again for raising this issue!

I'm also able to confirm you can already add tags. I've successfully managed to add two tags on a profile using the following code:

resource "aws_route53profiles_profile" "dev" {
  name = "example"

  tags = {
    IssueNumber = "40241"
    IssueLink = "https://github.com/hashicorp/terraform-provider-aws/issues/40241"
  }
}

[ineednewpajamas]

That does seem to be the case, I didn't have a chance to dig into the code before. Thanks for looking.

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.