-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(route53profiles): improve documentation about tags usage. #40284
fix(route53profiles): improve documentation about tags usage. #40284
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@jeremychauvet Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR aims to clarify usage of
tags
arguments on the following resources:aws_route53profiles_profile
aws_route53profiles_association
➡️ Code is already present, but documentation is missing.
Relations
Closes #40241.
Relates #39661.
Relates #38172.
References
I have checked provider behaviour using the following code, based on version
5.77.0
:Running a
terraform plan
command on this code output the following:And
![image](https://private-user-images.githubusercontent.com/20825264/389198600-5093c4c6-513a-43aa-a3b8-fcffd604a19a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4ODg0MTcsIm5iZiI6MTczOTg4ODExNywicGF0aCI6Ii8yMDgyNTI2NC8zODkxOTg2MDAtNTA5M2M0YzYtNTEzYS00M2FhLWEzYjgtZmNmZmQ2MDRhMTlhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE4VDE0MTUxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ1YjhhNmNkOTYxNDM1NmNjYTlhZGE2OGYxZDkwM2M4NTFlNzc4ZWU1ODI3NGRkOTFkOGU1MWVkNzdjNzk0ZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wLdVBaOxk52V14OzhOvaXIHlWj_Bu3JTXwLa8dqsfIw)
terraform apply
: