Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53profiles): improve documentation about tags usage. #40284

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

jeremychauvet
Copy link
Contributor

@jeremychauvet jeremychauvet commented Nov 23, 2024

Description

This PR aims to clarify usage of tags arguments on the following resources:

  • aws_route53profiles_profile
  • aws_route53profiles_association

➡️ Code is already present, but documentation is missing.

Relations

Closes #40241.
Relates #39661.
Relates #38172.

References

I have checked provider behaviour using the following code, based on version 5.77.0:

resource "aws_route53profiles_profile" "dev" {
  name = "example"

  tags = {
    IssueNumber = "40241"
    IssueLink = "https://github.com/hashicorp/terraform-provider-aws/issues/40241"
  }
}

Running a terraform plan command on this code output the following:

Terraform will perform the following actions:

  # aws_route53profiles_profile.dev will be updated in-place
  ~ resource "aws_route53profiles_profile" "dev" {
        id             = "rp-dfc217049689400e"
        name           = "example"
      + tags           = {
          + "IssueLink"   = "https://github.com/hashicorp/terraform-provider-aws/issues/40241"
          + "IssueNumber" = "40241"
        }
      ~ tags_all       = {
          + "IssueLink"   = "https://github.com/hashicorp/terraform-provider-aws/issues/40241"
          + "IssueNumber" = "40241"
        }
        # (5 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

And terraform apply:
image

@jeremychauvet jeremychauvet requested a review from a team as a code owner November 23, 2024 13:04
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/route53profiles Issues and PRs that pertain to the route53profiles service. needs-triage Waiting for first response or review from a maintainer. labels Nov 23, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 5, 2024
@ewbankkit ewbankkit added the tags Pertains to resource tagging. label Dec 5, 2024
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@jeremychauvet Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit fbc0ab8 into hashicorp:main Dec 5, 2024
28 checks passed
@github-actions github-actions bot added this to the v5.81.0 milestone Dec 5, 2024
Copy link

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/route53profiles Issues and PRs that pertain to the route53profiles service. tags Pertains to resource tagging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add tags support for aws_route53profiles_profile and aws_route53profiles_association
3 participants