Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ssm_patch_baseline operating_system CENTOS missing #4170

Closed
ghost opened this issue Apr 11, 2018 · 3 comments
Closed

aws_ssm_patch_baseline operating_system CENTOS missing #4170

ghost opened this issue Apr 11, 2018 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@ghost
Copy link

ghost commented Apr 11, 2018

This issue was originally opened by @bratdim as hashicorp/terraform#17836. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version

./terraform version
Terraform v0.11.7
+ provider.aws v1.14.0

Terraform Configuration Files

resource "aws_ssm_patch_baseline" "patch-baseline-centos" {
  name  = "CentOS_Linux"
  operating_system = "CENTOS"
  description = "CentOS Linux baseline"
  approved_patches_compliance_level = "CRITICAL"

  approval_rule = {
    approve_after_days = 7
    compliance_level = "CRITICAL"
    patch_filter = {
      key = "SEVERITY"
      values = ["Critical"]
    }
  }
...
}

Debug Output

2018/04/11 09:58:16 [TRACE] root: eval: *terraform.EvalValidateResource
2018/04/11 09:58:16 [ERROR] root: eval: *terraform.EvalSequence, err: Warnings: []. Errors: [expected operating_system to be one of [WINDOWS AMAZON_LINUX UBUNTU REDHAT_ENTERPRISE_LINUX], got CENTOS]
2018/04/11 09:58:16 [TRACE] [walkValidate] Exiting eval tree: aws_ssm_patch_baseline.patch-baseline-centos

Expected Behavior

Terraform should create patch baseline for Centos (like it does for Amazon linux, Suse or Windows)

Actual Behavior

Terrafrom fails with error:

./terraform plan

Error: aws_ssm_patch_baseline.patch-baseline-centos: expected operating_system to be one of [WINDOWS AMAZON_LINUX UBUNTU REDHAT_ENTERPRISE_LINUX], got CENTOS

Steps to Reproduce

  1. terraform init
  2. add mentioned aws_ssm_patch_baseline to main.tf
  3. terraform plan

References

AWS documentation regarding it:
https://docs.aws.amazon.com/systems-manager/latest/APIReference/API_GetDefaultPatchBaseline.html#API_GetDefaultPatchBaseline_ResponseElements

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. labels Apr 20, 2018
@bflad bflad added this to the v1.16.0 milestone Apr 20, 2018
@bflad bflad closed this as completed in ca2251c Apr 20, 2018
bflad added a commit that referenced this issue Apr 20, 2018
@bflad
Copy link
Contributor

bflad commented Apr 20, 2018

The new operation_system value has been added to the validation via #4268 and will release with v1.16.0 of the AWS provider, likely mid next week. 👍

@bflad
Copy link
Contributor

bflad commented Apr 25, 2018

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link
Author

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

No branches or pull requests

1 participant