Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to aws_codedeploy_deployment_config resource should result in resource being destroyed and recreated #4192

Closed
caramcc opened this issue Apr 12, 2018 · 6 comments · Fixed by #4194
Labels
bug Addresses a defect in current functionality.
Milestone

Comments

@caramcc
Copy link

caramcc commented Apr 12, 2018

Terraform attempts to make changes to aws_codedeploy_deployment_config resource, rather than destroy/recreate. AWS does not support updating this resource.

Terraform Version

0.10.8
AWS provider version 1.4

Affected Resource(s)

  • aws_codedeploy_deployment_config

Terraform Configuration Files

Example Usage resources

Expected Behavior

The deployment config is destroyed and recreated with the change reflected

Actual Behavior

Apply fails with * aws_codedeploy_deployment_config.deployment_config: doesn't support update

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform apply to create a aws_codedeploy_deployment_config resource
  2. modify the resource, e.g. set minimum_healthy_hosts.value to 1.
  3. terraform apply again
@bflad
Copy link
Contributor

bflad commented Apr 12, 2018

Thanks for the report @caramcc! I have submitted a bugfix PR for this: #4194

@caramcc
Copy link
Author

caramcc commented Apr 12, 2018

@bflad awesome, thanks!

I have a question about your PR:

It's also not possible to modify the deployment_configuration_name field (not just the minimum_healthy_hosts block), so changes to that field would also result in a failed apply.

Would it be feasible for a name_prefix option to be supported, like in the case of the aws_launch_configuration module, which also needs to be destroyed and recreated and (like this resource) is frequently referenced by name in other resources?

@bflad
Copy link
Contributor

bflad commented Apr 12, 2018

Sounds reasonable, I would create a separate issue for that enhancement. 😄 I won't personally have time to implement it, but maybe someone in the community will.

@bflad
Copy link
Contributor

bflad commented Apr 13, 2018

The force new resource fix is now merged into master and will release with v1.15.0 of the AWS provider. As I mentioned yesterday, I would suggest creating a new issue for supporting name_prefix 👍

@bflad
Copy link
Contributor

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
2 participants