Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_codedeploy_deployment_config: Force new resource for minimum_healthy_hosts updates #4194

Merged
merged 1 commit into from
Apr 13, 2018
Merged

resource/aws_codedeploy_deployment_config: Force new resource for minimum_healthy_hosts updates #4194

merged 1 commit into from
Apr 13, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 12, 2018

Fixes: #4192

Previously (before schema changes):

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeDeployDeploymentConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeDeployDeploymentConfig -timeout 120m
=== RUN   TestAccAWSCodeDeployDeploymentConfig_fleetPercent
--- FAIL: TestAccAWSCodeDeployDeploymentConfig_fleetPercent (17.96s)
	testing.go:518: Step 1 error: Error applying: 1 error(s) occurred:

		* aws_codedeploy_deployment_config.foo: 1 error(s) occurred:

		* aws_codedeploy_deployment_config.foo: doesn't support update
=== RUN   TestAccAWSCodeDeployDeploymentConfig_hostCount
--- FAIL: TestAccAWSCodeDeployDeploymentConfig_hostCount (16.40s)
	testing.go:518: Step 1 error: Error applying: 1 error(s) occurred:

		* aws_codedeploy_deployment_config.foo: 1 error(s) occurred:

		* aws_codedeploy_deployment_config.foo: doesn't support update
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	34.395s
make: *** [testacc] Error 1

After:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeDeployDeploymentConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeDeployDeploymentConfig -timeout 120m
=== RUN   TestAccAWSCodeDeployDeploymentConfig_fleetPercent
--- PASS: TestAccAWSCodeDeployDeploymentConfig_fleetPercent (20.99s)
=== RUN   TestAccAWSCodeDeployDeploymentConfig_hostCount
--- PASS: TestAccAWSCodeDeployDeploymentConfig_hostCount (22.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.259s

@bflad bflad added bug Addresses a defect in current functionality. service/codedeploy labels Apr 12, 2018
@bflad bflad added this to the v1.15.0 milestone Apr 12, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 12, 2018
@bflad bflad requested a review from a team April 12, 2018 18:10
@bflad bflad mentioned this pull request Apr 12, 2018
Closed
katbyte
katbyte reviewed Apr 12, 2018
View reviewed changes
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit d016a98 into master Apr 13, 2018
@bflad bflad deleted the b-aws_codedeploy_deployment_config-forcenew branch April 13, 2018 13:39
bflad added a commit that referenced this pull request Apr 13, 2018
@bflad
Update CHANGELOG for #4194
b23ed54
@bflad
Copy link
Contributor Author

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte left review comments

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Changes to aws_codedeploy_deployment_config resource should result in resource being destroyed and recreated
2 participants
@bflad @katbyte