Terraform volume tags changes on alternate run if defined in both aws_instance and aws_ebs_volume resources

[ghost]

This issue was originally opened by @saveshnshetty as hashicorp/terraform#18713. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Hi team,
I've defined volume tags in aws_instance resource and aws_ebs_volume resource since I need to add tags to root volume also. But when I ran "terraform apply" second time. Ebs volumes tags got replaced with aws instance volume tags. On third run it got replaced with original ebs volume tags .
This tags changes alternatively . Can you please look into it .

syntax :
resource "aws_instance" "app" {
count = "1"
ami = "${lookup(var.ami,var.region)}"
ebs_optimized = "${var.ebs_optimized}"
instance_type = "${var.instance_type_app}"
monitoring = "${var.monitoring}"
key_name = "${var.key_name}"
user_data = "${data.template_file.userdata-app..rendered[count.index]}"
network_interface {
network_interface_id = "${element(aws_network_interface.network-interface-app..id, count.index)}"
device_index = 0
}
tags {
Name = "$app-${count.index + 1}"
Type = "app"
Env = "${var.env}"
Customer_id = "${var.customer_id}"
}

	root_block_device {
		volume_type           = "${var.root_volume_type}"
		volume_size           = "${var.root_volume_size}"
		delete_on_termination = "${var.root_delete_on_termination}"
	}


	volume_tags {
		Name                  = "${var.env}-s4hana-app-${count.index + 1}"
		Type                  = "root-volume"
		Env                   = "${var.env}"
        Customer_id           = "${var.customer_id}"
	}

}

resource "aws_ebs_volume" "ebs-app" {
count = "${var.app_count}"
availability_zone = "****"
size = "${var.ebs_volume_size[0]}"
type = "${var.ebs_volume_type[0]}"
tags {
Name = "app-tmp"
Type = "ebs-volume"
Env = "${var.env}"
Customer_id = "${var.customer_id}"
}
}

[af6140]

was seeing this also for a while.

[af6140]

similar issue with #5080

[soumitmishra]

+1

[sadok-f]

we have a similar issue

[mrg2k8]

I've also run into this issue.

[sushilchaudhari]

Same issue. Is there any solution?

[Nklya]

They don't actually change, so you can ignore it.

[marobota]

I can see this happening too
Terraform v0.12.8

• provider.aws v2.31.0
  Ignoring this (as suggested above) is not good enough as the plan should stay clean if nothing is to be changed..

[zenbiking]

To add on to what @marobota said,

• this is still occurring with aws provider 2.31.0
• Contrary to what @Nklya stated, the tags are getting changed on my aws_ebs_volume resources
• I am also seeing only one of my 5 defined tags being applied to the root volume.

Something definitely isn't right.

[abhineetraj]

This is still happening.

An execution plan has been generated and is shown below.

Resource actions are indicated with the following symbols:
 ~ update in-place

Terraform will perform the following actions:

 ~ aws_instance.google-prod-app
     volume_tags.Name: "google-prod-app-001:/root" => "google-prod-app-001"


Plan: 0 to add, 1 to change, 0 to destroy.

------------------------------------------------------------------------

Note: You didn't specify an "-out" parameter to save this plan, so Terraform
can't guarantee that exactly these actions will be performed if
"terraform apply" is subsequently run.

[VladislavAnd]

There is a workaround:
Remove volume_tags from your aws_instance and add the following aws_ec2_tag:

resource "aws_ec2_tag" "root_volume_tags" {
  resource_id = aws_instance.this.root_block_device[0].volume_id
  key         = "Name"
  value       = "VALUE"
}  

[PTATH81]

Are there any plans to address this? I am also seeing this issue

[mdelagrange]

The behavior seems to be worse with the latest versions of Terraform and the AWS provider. Now, under some circumstances, tags can be removed from volumes even if volume_tags isn't defined on the aws_instance resource. (See #17074 for an example.). It's the same alternating removal of volume tags, but now it's significantly more difficult to predict or avoid.

[YakDriver]

We have merged a fix to the volume_tags issue in #15474. We have added tests to cover the issues observed. Please note that using volume_tags in aws_instance is not compatible with using tags in aws_ebs_volume. You need to use one or the other. Prior to this fix, even following this rule, you would encounter errors. Along with the fix, we've added tags to the root_block_device and ebs_block_device configuration blocks in aws_instance.

Now that the fix is in place, if you find any problems with volume_tags, let us know by opening a new issue.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!