Expose naked aws_mq_broker hostname

[izeau]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently aws_mq_broker resources only expose their hostname via console_url and the endpoints list under the instances list:

aws_mq_broker.broker:
  instances:
    - console_url: 'https://<hostname>:8162'
      endpoints:
        - 'ssl://<hostname>:61617'
        - 'amqp+ssl://<hostname>:5671'
        - 'stomp+ssl://<hostname>:61614'
        - 'mqtt+ssl://<hostname>:8883'
        - 'wss://<hostname>:61619'

I'd like to access the hostname directly in order to create CNAME for it. At the time I’m using multiple replace() calls to remove the protocol and port but it's kind of a pain, plus the nested structure makes it quite difficult to access them when using an arbitrary number of instances.

Maybe a hostname attribute on the instances field would help.

New or Affected Resource(s)

• aws_mq_broker

[chrislewisdev]

The AWS SDK exposes an IpAddress field on every Broker Instance - https://docs.aws.amazon.com/sdk-for-go/api/service/mq/#BrokerInstance - if my understanding is correct, that should allow this to be supported fairly easily.

I'd like to have a go at putting together a PR for this issue as my first Terraform contribution - so keep your eyes peeled :)

[chrislewisdev]

It's worth noting that the IpAddress field of course lists only the IP Address and not the exact same hostname value (e.g. xxxx-xxxxx-xxxx.mq.ap-southeast-2.amazonaws.com) that you're looking for. Would exposing the raw IP Address solve your needs the same way that hostname would? Seeing as you're looking to create DNS records for it, I'm under the impression that it should suit just as well.

[chrislewisdev]

I just opened a PR to add the new ip_address property. Although I feel this is a worthwhile contribution on its own, I'd definitely like to know if this will address your needs @izeau! If it doesn't, I guess additional PRs would be required to add the exact hostname property you're looking for.

[izeau]

That is perfect @chrislewisdev! Thanks a lot.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!