-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ip_address property to aws_mq_broker instances list #6103
Conversation
Update with acceptance test results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @chrislewisdev! 🚀
--- PASS: TestAccAWSMqBroker_basic (960.52s)
--- PASS: TestAccAWSMqBroker_updateUsers (1367.97s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (1852.07s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (1911.28s)
This has been released in version 1.40.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Potential fix for #5913.
Changes proposed in this pull request:
IpAddress
property returned by the AWS SDK for Amazon MQ Broker InstancesOutput from acceptance testing:
I wasn't able to run the full set of acceptance tests for
aws_mq_broker
last night, but runningTestAccAWSMqBroker_basic
passed. I'll have another shot at running the other tests later today.