Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Out getStringPtr() and getStringPtrList() #5983

Closed
bflad opened this issue Sep 25, 2018 · 2 comments · Fixed by #12581
Closed

Refactor Out getStringPtr() and getStringPtrList() #5983

bflad opened this issue Sep 25, 2018 · 2 comments · Fixed by #12581
Assignees
@bflad
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone
v2.56.0

Comments

@bflad
Copy link
Contributor

bflad commented Sep 25, 2018

They aren't used much but we should be using the standard ResourceData/map and AWS Go SDK functions in their place to match the rest of the codebase and remove the indirection.
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 25, 2018
@bflad bflad self-assigned this Sep 25, 2018
@bflad bflad mentioned this issue Nov 2, 2018
Merged
@ryndaniels ryndaniels self-assigned this Aug 19, 2019
@ryndaniels ryndaniels removed their assignment Oct 31, 2019
@bflad bflad mentioned this issue Jan 3, 2020
Merged
@bflad bflad removed their assignment Feb 29, 2020
@bflad bflad mentioned this issue Feb 29, 2020
Merged
This was referenced Mar 29, 2020
Merged
Merged
@bflad bflad self-assigned this Apr 1, 2020
@bflad bflad added this to the v2.56.0 milestone Apr 1, 2020
@ewbankkit ewbankkit mentioned this issue Apr 1, 2020
Closed
@ghost
Copy link

ghost commented Apr 3, 2020

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.56.0
Development

Successfully merging a pull request may close this issue.

r/elastic_transcoder_preset remove stringptr + refactor DrFaust92/terraform-provider-aws
2 participants
@bflad @ryndaniels