Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Fix unparam Linting Issues and Enable in TravisCI Testing #6338

Merged
merged 2 commits into from
Nov 4, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 2, 2018

Closes #6336
Reference #5983

Changes proposed in this pull request:

  • Fixing straightforward unparam linting issues such as unused parameters
  • Exporting functions flagged by unparam that will eventually be migrated into their own packages (ones that should keep their same function signature)
  • Removing getStringPtrList() which is part of Refactor Out getStringPtr() and getStringPtrList() #5983 👍

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (45.41s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (47.51s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (7.63s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (63.25s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (12.13s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (77.29s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (80.07s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (25.72s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (81.66s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (6.60s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (12.30s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (87.92s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (87.87s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (58.59s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (105.01s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (138.59s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (167.31s)
--- PASS: TestAccAWSAutoScalingGroup_importBasic (168.45s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (198.27s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (198.89s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (233.74s)
--- PASS: TestAccAWSAutoScalingGroup_basic (262.05s)
--- PASS: TestAccAWSAutoScalingGroup_tags (265.68s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (287.56s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (290.00s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (342.91s)
--- PASS: TestAccAWSEMRCluster_basic (372.71s)
--- PASS: TestAccAWSEMRCluster_security_config (385.79s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (414.18s)
--- PASS: TestAccAWSEMRCluster_instance_group_EBSVolumeType_st1 (419.35s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (428.42s)
--- PASS: TestAccAWSEMRCluster_instance_group (453.19s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (541.96s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (421.97s)
--- PASS: TestAccAWSEMRCluster_keepJob (393.11s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (487.94s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (467.78s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (530.79s)
--- PASS: TestAccAWSEMRCluster_s3Logging (597.50s)
--- PASS: TestAccAWSEMRCluster_tags (612.83s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (586.37s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (746.05s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (705.99s)

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. labels Nov 2, 2018
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/batch Issues and PRs that pertain to the batch service. service/cloudwatchevents service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/opsworks Issues and PRs that pertain to the opsworks service. service/redshift Issues and PRs that pertain to the redshift service. service/ses Issues and PRs that pertain to the ses service. labels Nov 2, 2018
@bflad bflad requested a review from a team November 2, 2018 22:18
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.43.0 milestone Nov 4, 2018
@bflad bflad merged commit 09e8156 into master Nov 4, 2018
@bflad bflad deleted the td-unparam branch November 4, 2018 21:44
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/batch Issues and PRs that pertain to the batch service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/opsworks Issues and PRs that pertain to the opsworks service. service/redshift Issues and PRs that pertain to the redshift service. service/ses Issues and PRs that pertain to the ses service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech Debt: Fix unparam Linting Issues and Enable in TravisCI
2 participants