Tech Debt: Fix unparam Linting Issues and Enable in TravisCI

[bflad]

And the beat goes on... 🎉

• Fix existing gometalinter --disable-all --enable unparam ./aws issues

aws/autoscaling_tags.go:265:35:warning: parameter key always receives "key" (unparam)
aws/awserr.go:27:47:warning: parameter message always receives "send request failed" (unparam)
aws/awserr.go:27:34:warning: parameter code always receives "RequestError" (unparam)
aws/awserr.go:51:70:warning: parameter result 0 (interface{}) is never used (unparam)
aws/ecs_task_definition_equivalency.go:16:84:warning: parameter result 1 (error) is never used (unparam)
aws/resource_aws_api_gateway_stage.go:414:23:warning: parameter prefix always receives "/variables/" (unparam)
aws/resource_aws_athena_database.go:178:52:warning: parameter d is unused (unparam)
aws/resource_aws_athena_database.go:204:50:warning: parameter d is unused (unparam)
aws/resource_aws_batch_job_queue.go:165:43:warning: parameter timeout always receives 600000000000 (unparam)
aws/resource_aws_batch_job_queue.go:186:44:warning: parameter timeout always receives 600000000000 (unparam)
aws/resource_aws_cloudwatch_event_rule.go:284:32:warning: parameter length always receives 2048 (unparam)
aws/resource_aws_codedeploy_app.go:170:50:warning: parameter result 0 (string) is never used (unparam)
aws/resource_aws_directory_service_directory.go:493:108:warning: parameter timeout always receives 3600000000000 (unparam)
aws/resource_aws_elasticache_cluster.go:631:28:warning: parameter d is unused (unparam)
aws/resource_aws_elasticache_replication_group.go:778:95:warning: parameter givenState is unused (unparam)
aws/resource_aws_elasticache_replication_group.go:825:67:warning: parameter timeout always receives 2400000000000 (unparam)
aws/resource_aws_emr_cluster.go:1096:43:warning: parameter typ always receives "CORE" (unparam)
aws/resource_aws_emr_cluster.go:1352:78:warning: parameter result 1 (error) is never used (unparam)
aws/resource_aws_iam_policy_attachment.go:267:57:warning: parameter meta is unused (unparam)
aws/resource_aws_iam_policy_attachment.go:289:57:warning: parameter meta is unused (unparam)
aws/resource_aws_iam_policy_attachment.go:311:58:warning: parameter meta is unused (unparam)
aws/resource_aws_kms_grant.go:471:50:warning: parameter sep always receives "-" (unparam)
aws/resource_aws_launch_template.go:928:54:warning: parameter meta is unused (unparam)
aws/resource_aws_opsworks_instance.go:913:69:warning: parameter wait always receives true (unparam)
aws/resource_aws_opsworks_instance.go:951:84:warning: parameter meta is unused (unparam)
aws/resource_aws_opsworks_instance.go:951:31:warning: parameter d is unused (unparam)
aws/resource_aws_proxy_protocol_policy.go:262:56:warning: parameter result 0 (string) is never used (unparam)
aws/resource_aws_redshift_cluster.go:915:92:warning: parameter result 0 (interface{}) is never used (unparam)
aws/resource_aws_ses_receipt_rule.go:601:47:warning: parameter meta is unused (unparam)
aws/resource_aws_vpn_gateway.go:296:65:warning: parameter expected is unused (unparam)
aws/structure.go:1895:65:warning: parameter listName always receives "layer_ids" (unparam)
aws/structure.go:1968:49:warning: parameter key always receives "access" (unparam)
aws/validators.go:697:49:warning: parameter k always receives "name" (unparam)
aws/validators.go:709:46:warning: parameter k always receives "name" (unparam)
aws/validators.go:1680:53:warning: parameter k always receives "roles" (unparam)
aws/waf_token_handlers.go:47:35:warning: parameter region always receives "global" (unparam)

• Enable unparam in TravisCI via .gometalinter.json configuration

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!