Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Version 2 Release] resource/aws_api_gateway_api_key: Remove deprecated stage_key argument #7677

Closed
bflad opened this issue Feb 24, 2019 · 2 comments · Fixed by #7698
Closed
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Feb 24, 2019

Description

Tracking issue for https://www.terraform.io/docs/providers/aws/guides/version-2-upgrade.html#resource-aws_api_gateway_api_key

stage_key Argument Removal

Since the API Gateway usage plans feature was launched on August 11, 2016, usage plans are now required to associate an API key with an API stage. To migrate your Terraform configuration, the AWS provider implements support for usage plans with the following resources:

@bflad bflad added service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 24, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 24, 2019
bflad added a commit that referenced this issue Feb 24, 2019
…ration block

Reference: #7677

Changes:

* Remove deprecated `stage_key` configuration block
* Remove extraneous `resource.Retry()` wrapping in deletion
* Return errors instead of logging when unable to set `created_date` and `last_updated_date` attributes in Terraform state
* Add acceptance test for setting `description` during creation and update
* Add acceptance test for setting `enabled` during creation and update

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayApiKey_basic (9.90s)
--- PASS: TestAccAWSAPIGatewayApiKey_Value (9.93s)
--- PASS: TestAccAWSAPIGatewayApiKey_Description (14.30s)
--- PASS: TestAccAWSAPIGatewayApiKey_Enabled (15.15s)
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (55.67s)
```
@bflad
Copy link
Contributor Author

bflad commented Feb 24, 2019

Pull request submitted: #7698

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
1 participant