[Version 2 Release] resource/aws_route53_zone: Remove deprecated top-level vpc_id and vpc_region arguments

[bflad]

Description

Tracking issue for https://www.terraform.io/docs/providers/aws/guides/version-2-upgrade.html#resource-aws_route53_zone

vpc_id and vpc_region Argument Removal

Switch your Terraform configuration to vpc configuration block(s) instead.

For example, given this previous configuration:

resource "aws_route53_zone" "example" {
  # ... other configuration ...

  vpc_id = "..."
}

An updated configuration:

resource "aws_route53_zone" "example" {
  # ... other configuration ...

  vpc {
    vpc_id = "..."
  }
}

[bflad]

Pull request submitted: #7695

[mrozentsvayg]

Unfortunately, vpc block does not work as expected with aws_route53_zone_association.
For the simple code:

resource "aws_route53_zone" "xx" {
  name = "xx.test"
  vpc {
    vpc_id = "vpc-11111111"
  }
}

resource "aws_route53_zone_association" "xx" {
  zone_id    = "${aws_route53_zone.xx.zone_id}"
  vpc_id     = "vpc-22222222"
  vpc_region = "us-west-1"
}

association with another vpc will be initially created, removed with next apply, then created again and so on.
Output from subsequent runs provided below (vpc and zone ids are masked).
Should i create a separate issue or it could be picked up from here?
With vpc_id it was working as intended.

→ terraform version
Terraform v0.11.13
+ provider.aws v2.1.0
+ provider.null v2.1.0
+ provider.template v2.1.0

Terraform will perform the following actions:

  + aws_route53_zone.xx
      id:                        <computed>
      comment:                   "Managed by Terraform"
      force_destroy:             "false"
      name:                      "xx.test"
      name_servers.#:            <computed>
      vpc.#:                     "1"
      vpc.2645171986.vpc_id:     "vpc-11111111"
      vpc.2645171986.vpc_region: <computed>
      vpc_id:                    <computed>
      vpc_region:                <computed>
      zone_id:                   <computed>

  + aws_route53_zone_association.xx
      id:                        <computed>
      vpc_id:                    "vpc-22222222"
      vpc_region:                "us-west-1"
      zone_id:                   "${aws_route53_zone.xx.zone_id}"

Plan: 2 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_route53_zone.xx: Creating...
  comment:                   "" => "Managed by Terraform"
  force_destroy:             "" => "false"
  name:                      "" => "xx.test"
  name_servers.#:            "" => "<computed>"
  vpc.#:                     "" => "1"
  vpc.2645171986.vpc_id:     "" => "vpc-11111111"
  vpc.2645171986.vpc_region: "" => "<computed>"
  vpc_id:                    "" => "<computed>"
  vpc_region:                "" => "<computed>"
  zone_id:                   "" => "<computed>"
aws_route53_zone.xx: Still creating... (10s elapsed)
aws_route53_zone.xx: Still creating... (20s elapsed)
aws_route53_zone.xx: Still creating... (30s elapsed)
aws_route53_zone.xx: Still creating... (40s elapsed)
aws_route53_zone.xx: Still creating... (50s elapsed)
aws_route53_zone.xx: Creation complete after 58s (ID: ZZZZZZZZZZZZZZ)
aws_route53_zone_association.xx: Creating...
  vpc_id:     "" => "vpc-22222222"
  vpc_region: "" => "us-west-1"
  zone_id:    "" => "ZZZZZZZZZZZZZZ"
aws_route53_zone_association.xx: Still creating... (10s elapsed)
aws_route53_zone_association.xx: Still creating... (20s elapsed)
aws_route53_zone_association.xx: Still creating... (30s elapsed)
aws_route53_zone_association.xx: Still creating... (40s elapsed)
aws_route53_zone_association.xx: Creation complete after 47s (ID: ZZZZZZZZZZZZZZ:vpc-22222222)

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

Terraform will perform the following actions:

  ~ aws_route53_zone.xx
      vpc.#:                 "2" => "1"
      vpc.1474358627.vpc_id: "vpc-22222222" => ""
      vpc.2645171986.vpc_id: "vpc-11111111" => "vpc-11111111"


Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_route53_zone.xx: Modifying... (ID: ZZZZZZZZZZZZZZ)
  vpc.#:                 "2" => "1"
  vpc.1474358627.vpc_id: "vpc-22222222" => ""
  vpc.2645171986.vpc_id: "vpc-11111111" => "vpc-11111111"
aws_route53_zone.xx: Still modifying... (ID: ZZZZZZZZZZZZZZ, 10s elapsed)
aws_route53_zone.xx: Still modifying... (ID: ZZZZZZZZZZZZZZ, 20s elapsed)
aws_route53_zone.xx: Still modifying... (ID: ZZZZZZZZZZZZZZ, 30s elapsed)
aws_route53_zone.xx: Still modifying... (ID: ZZZZZZZZZZZZZZ, 40s elapsed)
aws_route53_zone.xx: Modifications complete after 47s (ID: ZZZZZZZZZZZZZZ)

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Terraform will perform the following actions:

  + aws_route53_zone_association.xx
      id:         <computed>
      vpc_id:     "vpc-22222222"
      vpc_region: "us-west-1"
      zone_id:    "ZZZZZZZZZZZZZZ"

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_route53_zone_association.xx: Creating...
  vpc_id:     "" => "vpc-22222222"
  vpc_region: "" => "us-west-1"
  zone_id:    "" => "ZZZZZZZZZZZZZZ"
aws_route53_zone_association.xx: Still creating... (10s elapsed)
aws_route53_zone_association.xx: Still creating... (20s elapsed)
aws_route53_zone_association.xx: Still creating... (30s elapsed)
aws_route53_zone_association.xx: Still creating... (40s elapsed)
aws_route53_zone_association.xx: Creation complete after 47s (ID: ZZZZZZZZZZZZZZ:vpc-22222222)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Terraform will perform the following actions:

  ~ aws_route53_zone.xx
      vpc.#:                 "2" => "1"
      vpc.1474358627.vpc_id: "vpc-22222222" => ""
      vpc.2645171986.vpc_id: "vpc-11111111" => "vpc-11111111"


Plan: 0 to add, 1 to change, 0 to destroy.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!