Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nodejs10.x runtime in Lambda #8627

Closed
hhakkala opened this issue May 14, 2019 · 5 comments · Fixed by #8622
Closed

Support nodejs10.x runtime in Lambda #8627

hhakkala opened this issue May 14, 2019 · 5 comments · Fixed by #8622
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Milestone

Comments

@hhakkala
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Specifying nodejs10.x as function runtime currently results in validation error:

$ terraform -v
Terraform v0.11.13
+ provider.aws v2.10.0

$ terraform apply
Error: module.default.aws_lambda_function.default: expected runtime to be one of [dotnetcore1.0 dotnetcore2.0 dotnetcore2.1 go1.x java8 nodejs4.3 nodejs4.3-edge nodejs6.10 nodejs8.10 provided python2.7 python3.6 python3.7 ruby2.5], got nodejs10.x

New or Affected Resource(s)

  • aws_lambda_function

Potential Terraform Configuration

resource "aws_lambda_function" "default" {
  function_name = "MyFunction"
  ...
  runtime = "nodejs10.x"
}

References

@hhakkala hhakkala added the enhancement Requests to existing resources that expand the functionality or scope. label May 14, 2019
@acburdine
Copy link
Contributor

I've got a PR open to add support here: #8622

@hhakkala hhakkala changed the title Support nodejs10.x runtime in Lambda Support nodejs10.x runtime in Lambda May 14, 2019
@bflad bflad added the service/lambda Issues and PRs that pertain to the lambda service. label May 14, 2019
@bflad bflad added this to the v2.11.0 milestone May 14, 2019
@bflad
Copy link
Contributor

bflad commented May 14, 2019

Support for the new nodejs10.x runtime in the aws_lambda_function resource has been merged and will be released with version 2.11.0 of the Terraform AWS Provider later this week. 👍

@bflad
Copy link
Contributor

bflad commented May 17, 2019

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 21, 2019

The docs should be updated to reflect support for the new nodejs version (nodejs8 is being deprecated).
https://www.terraform.io/docs/providers/aws/r/lambda_function.html#basic-example
I clicked edit this page but could not understand where to make the change.

@ghost
Copy link

ghost commented Nov 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants