Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NodeJS v8.10.0 runtime in Lambda functions #4019

Closed
clocked0ne opened this issue Apr 3, 2018 · 2 comments
Closed

Support NodeJS v8.10.0 runtime in Lambda functions #4019

clocked0ne opened this issue Apr 3, 2018 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Milestone

Comments

@clocked0ne
Copy link

Terraform Version

0.10.8

Affected Resource(s)

Please list the resources as a list, for example:

  • aws_lambda_function

Expected Behavior

Should successfully build with latest Node v8.10.0 runtime

Actual Behavior

Error: module.babelfish_ref.aws_lambda_function.module_lambda: expected runtime to be one of [nodejs4.3 nodejs6.10 java8 python2.7 python3.6 dotnetcore1.0 dotnetcore2.0 nodejs4.3-edge go1.x], got nodejs8.10

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform apply

Important Factoids

Change needs to be made here in terraform-provider-aws/aws/resource_aws_lambda_function.go

"runtime": {
	Type:     schema.TypeString,
	Required: true,
	ValidateFunc: validation.StringInSlice([]string{
		// lambda.RuntimeNodejs has reached end of life since October 2016 so not included here
		lambda.RuntimeNodejs43,
		lambda.RuntimeNodejs610,
		lambda.RuntimeJava8,
		lambda.RuntimePython27,
		lambda.RuntimePython36,
		lambda.RuntimeDotnetcore10,
		lambda.RuntimeDotnetcore20,
		lambda.RuntimeNodejs43Edge,
		lambda.RuntimeGo1X,
	}, false),
},
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. labels Apr 3, 2018
bflad added a commit that referenced this issue Apr 3, 2018
Support NodeJS v8.10.0 runtime in Lambda functions #4019
@bflad bflad added this to the v1.14.0 milestone Apr 3, 2018
@bflad
Copy link
Contributor

bflad commented Apr 3, 2018

While the SDK hasn't been updated to support the new constant, we merged in support via #4020. It will be released with v1.14.0 of the AWS provider, likely later this week. 🎉

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
Development

No branches or pull requests

2 participants