Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon API Gateway additional resource tagging #8744

Closed
ewbankkit opened this issue May 22, 2019 · 4 comments
Closed

Amazon API Gateway additional resource tagging #8744

ewbankkit opened this issue May 22, 2019 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service.
Milestone
v2.37.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented May 22, 2019 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

As of AWS SDK v1.19.36 additional Amazon API Gateway resources can be tagged:

This release adds support for tagging of Amazon API Gateway resources.

Requires:

Announcement.
Developer guide.

aws_api_gateway_stage resources already supported resource tags - #2858.
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label May 22, 2019
@ewbankkit
Copy link
Contributor Author

ewbankkit commented May 22, 2019 •
edited by bflad
Loading

Affected resources:

@bflad bflad added the service/apigateway Issues and PRs that pertain to the apigateway service. label May 22, 2019
@ewbankkit ewbankkit mentioned this issue Oct 20, 2019
Merged
@ewbankkit ewbankkit changed the title Amazon API Gateway tagging Amazon API Gateway additional resource tagging Oct 20, 2019
@ewbankkit ewbankkit mentioned this issue Oct 20, 2019
Closed
This was referenced Oct 20, 2019
Merged
Merged
Merged
Merged
Merged
@ewbankkit ewbankkit mentioned this issue Nov 8, 2019
Closed
@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
@bflad
Copy link
Contributor

bflad commented Nov 15, 2019

Resource tagging with API Gateway resources that support it directly (others inherit tags from parent resources) has now been merged. Tagging for the last remaining resource in this feature request, aws_api_gateway_rest_api, will release with version 2.37.0 of the Terraform AWS Provider, by Thursday next week. Thanks to @stephentyellis and @DrFaust92 for their implementations. 🚀

@bflad bflad closed this as completed Nov 15, 2019
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@bflad
Copy link
Contributor

bflad commented Dec 5, 2019

Please note that due to some strange behavior with GitHub's Squash and Merge functionality, the aws_api_gateway_usage_plan tagging enhancements will go out in version 2.42.0 of the Terraform AWS Provider.

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service.
Projects
None yet
Milestone
v2.37.0
Development

No branches or pull requests
2 participants
@bflad @ewbankkit