Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tag Support to API Gateway API Key Resource #10568

Merged
merged 6 commits into from
Nov 4, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8744

Release note for CHANGELOG:

- resource/resource_aws_api_gateway_api_key: Add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayApiKey_'

=== RUN   TestAccAWSAPIGatewayApiKey_basic
=== PAUSE TestAccAWSAPIGatewayApiKey_basic
=== CONT  TestAccAWSAPIGatewayApiKey_basic
--- PASS: TestAccAWSAPIGatewayApiKey_basic (29.75s)
=== RUN   TestAccAWSAPIGatewayApiKey_Tags
=== PAUSE TestAccAWSAPIGatewayApiKey_Tags
=== CONT  TestAccAWSAPIGatewayApiKey_Tags
--- PASS: TestAccAWSAPIGatewayApiKey_Tags (67.64s)
=== RUN   TestAccAWSAPIGatewayApiKey_Description
=== PAUSE TestAccAWSAPIGatewayApiKey_Description
=== CONT  TestAccAWSAPIGatewayApiKey_Description
--- PASS: TestAccAWSAPIGatewayApiKey_Description (47.29s)
=== RUN   TestAccAWSAPIGatewayApiKey_Enabled
=== PAUSE TestAccAWSAPIGatewayApiKey_Enabled
=== CONT  TestAccAWSAPIGatewayApiKey_Enabled
--- PASS: TestAccAWSAPIGatewayApiKey_Enabled (48.31s)
=== RUN   TestAccAWSAPIGatewayApiKey_Value
=== PAUSE TestAccAWSAPIGatewayApiKey_Value
=== CONT  TestAccAWSAPIGatewayApiKey_Value
--- PASS: TestAccAWSAPIGatewayApiKey_Value (29.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	106.370s

...

@DrFaust92 DrFaust92 requested a review from a team October 20, 2019 19:04
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 20, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 4, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 4, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

--- PASS: TestAccAWSAPIGatewayApiKey_Value (8.40s)
--- PASS: TestAccAWSAPIGatewayApiKey_basic (8.70s)
--- PASS: TestAccAWSAPIGatewayApiKey_Enabled (13.28s)
--- PASS: TestAccAWSAPIGatewayApiKey_Description (13.78s)
--- PASS: TestAccAWSAPIGatewayApiKey_Tags (18.67s)

@bflad bflad merged commit 07e304c into hashicorp:master Nov 4, 2019
bflad added a commit that referenced this pull request Nov 4, 2019
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the api-gateway-api-key-tag-support branch November 9, 2019 12:41
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants