Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct VIF type during import of Direct Connect Virtual Interfaces #8843

Closed
ewbankkit opened this issue Jun 3, 2019 · 4 comments · Fixed by #9572
Closed

Ensure correct VIF type during import of Direct Connect Virtual Interfaces #8843

ewbankkit opened this issue Jun 3, 2019 · 4 comments · Fixed by #9572
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_dx_private_virtual_interface, aws_dx_public_virtual_interface and aws_dx_transit_virtual_interface all support resource import via terraform import. As the same underlying AWS Direct Connect API call is used in all cases, it is possible to import e.g. a transit VIF as a private VIF. The API returns a VirtualInterfaceType property so we should check that this has the correct value before allowing the import to succeed.

Related:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 3, 2019
@bflad bflad added the service/directconnect Issues and PRs that pertain to the directconnect service. label Jun 4, 2019
ewbankkit pushed a commit to ewbankkit/terraform-provider-aws that referenced this issue Jul 30, 2019
@ewbankkit
Copy link
Contributor Author

Verifying correct VIF type while importing aws_dx_transit_virtual_interface, aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter implemented in #8522 and #8523 respectively.

@bflad
Copy link
Contributor

bflad commented Nov 25, 2019

This has been implemented for aws_dx_private_virtual_interface and aws_dx_public_virtual_interface via #9572 and will release with version 2.40.0 of the Terraform AWS Provider, later this week.

@ghost
Copy link

ghost commented Nov 27, 2019

This has been released in version 2.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Projects
None yet
2 participants