Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform always rebuild aws_network_acl when rules are capitalized #918

Closed
hauleth opened this issue Jun 20, 2017 · 1 comment · Fixed by #1000
Closed

Terraform always rebuild aws_network_acl when rules are capitalized #918

hauleth opened this issue Jun 20, 2017 · 1 comment · Fixed by #1000
Labels
bug Addresses a defect in current functionality.

Comments

@hauleth
Copy link

hauleth commented Jun 20, 2017

Terraform Version

Terraform v0.9.8

Affected Resource(s)

  • aws_network_acl

Terraform Configuration Files

resource "aws_network_acl" "acl" {
  vpc_id = "${module.network.vpc_id}"

  subnet_ids = [
    "${module.network.public_subnets}",
    "${module.network.private_subnets}",
    "${module.network.database_subnets}",
  ]

  ingress {
    action     = "Allow"
    from_port  = 0
    to_port    = 0
    protocol   = -1
    rule_no    = 1
    cidr_block = "0.0.0.0/0"
  }

  egress {
    action     = "Allow"
    from_port  = 0
    to_port    = 0
    protocol   = -1
    rule_no    = 2
    cidr_block = "0.0.0.0/0"
  }
}

Expected Behavior

To keep that configuration always.

Actual Behavior

It marks such configuration as tainted and rebuild it each time due to capitalisation of Apply.

Steps to Reproduce

  1. terraform apply

Fix

I believe that we should either compare case-independently in this case or downcase before comparison. Alternatively some warning would be nice.

stack72 added a commit that referenced this issue Jun 29, 2017
…itive

Fixes: #918

Add a diff suppress func to stop case sensitivity issues on the Action
param of ingress and egress. To do this, I had to make sure that the
hash always used the lowercase version (this will mean that users who do
not see a perpetual diff are not affected)
@stack72 stack72 added the bug Addresses a defect in current functionality. label Jun 29, 2017
@stack72 stack72 self-assigned this Jun 29, 2017
stack72 added a commit that referenced this issue Jun 29, 2017
…itive (#1000)

Fixes: #918

Add a diff suppress func to stop case sensitivity issues on the Action
param of ingress and egress. To do this, I had to make sure that the
hash always used the lowercase version (this will mean that users who do
not see a perpetual diff are not affected)
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost unassigned stack72 Apr 11, 2020
@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
2 participants