Update module golangci/golangci-lint to v1.18.0 #10054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/github.com-golangci-golangci-lint-1.x
branch
from
a136e4d to
4e5a2f3
Compare
ghost
added
size/XXL
renovate
bot
force-pushed
the
renovate/github.com-golangci-golangci-lint-1.x
branch
24 times, most recently
from
359356d to
7924baf
Compare
renovate
bot
force-pushed
the
renovate/github.com-golangci-golangci-lint-1.x
branch
20 times, most recently
from
c5df704 to
c48dcb3
Compare
renovate
bot
force-pushed
the
renovate/github.com-golangci-golangci-lint-1.x
branch
from
c48dcb3 to
32e45e2
Compare
bflad
added a commit
that referenced
this pull request
Sep 23, 2019
Reference: #9992 Reference: #10054 The main change here (and impetus because it seems to use too much memory in Go 1.12 for TravisCI to successfully pass linting) is upgrading github.com/golangci/golangci-lint to v1.18.0, which has fixes for Go 1.13 support in its listed dependencies. It was upgraded via: ```console $ go get github.com/golangci/golangci-lint@v1.18.0 $ go mod tidy $ go mod vendor ``` The addition of `go 1.13` to the `go.mod` file signals that this module should be built with that version of Go or later. Different than Go 1.12, any Go 1.13 command run against the module will always add that versioning information to the go.mod file. We add this once now to prevent unnecessary Git differences in the future. Development, testing, and building with Go 1.12 and earlier should not be affected as we are not introducing any breaking changes at the moment, but we do not officially support versions other than what is tested against via TravisCI. As a simple verification of the above statement: ```console $ go1.12 version go version go1.12.9 darwin/amd64 $ go1.12 test ./... ? github.com/terraform-providers/terraform-provider-aws [no test files] ok github.com/terraform-providers/terraform-provider-aws/aws 1.313s $ go1.12 build $ ``` Passes unit testing, linting, smoke acceptance testing, and release process cross-compilation testing. ```console $ TF_ACC=1 go test ./aws -v -timeout 120m -parallel 20 -run='TestAccAWSProvider' ... --- PASS: TestAccAWSProvider_Region_AwsCommercial (2.58s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.59s) --- PASS: TestAccAWSProvider_Region_AwsChina (2.60s) --- PASS: TestAccAWSProvider_Endpoints_Deprecated (2.72s) --- PASS: TestAccAWSProvider_Endpoints (2.80s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 3.846s $ gox -os='linux darwin windows freebsd openbsd solaris' -arch='386 amd64 arm' -osarch='!darwin/arm !darwin/386' -ldflags '-s -w -X aws/version.ProviderVersion=99.99.99 -X aws/version.ProtocolVersion=4' -output 'results/{{.OS}}_{{.Arch}}/terraform-provider-aws_v99.99.99_x4' . Number of parallel builds: 7 --> darwin/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/amd64: github.com/terraform-providers/terraform-provider-aws --> solaris/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/arm: github.com/terraform-providers/terraform-provider-aws --> windows/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/386: github.com/terraform-providers/terraform-provider-aws --> windows/386: github.com/terraform-providers/terraform-provider-aws --> freebsd/amd64: github.com/terraform-providers/terraform-provider-aws --> freebsd/arm: github.com/terraform-providers/terraform-provider-aws --> openbsd/386: github.com/terraform-providers/terraform-provider-aws --> openbsd/amd64: github.com/terraform-providers/terraform-provider-aws --> linux/386: github.com/terraform-providers/terraform-provider-aws ```
|
Superseded by #10206 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
added
the
linter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.17.1->v1.18.0Release Notes
golangci/golangci-lint
v1.18.0Compare Source
Changelog
bb82273Add funlen linter (#603)91e90ebAdd support for bash completions (#640)a8f2c27Add user supplied error messages in depguard issues (#662)f84095aBuild FreeBSD binaries (#613)e87a1cfFix a false-positive from 'unused' (#585)338e3fbFix install script on Windows (#626)0b49095Make generation of demo.svg deterministic (#625)eabe43aProvide pre-built binary for ARM arch (#607)375a5a8Speed up linting: use deduplicated packages (#667)6163a8aSupport go1.13 (#670)e1a7422Updategochecknoglobalsto support version exception (#601)f8a5a8cUpdate depguard version to 1.0.0 (Performance improvements)97fcafdUpdate format of junit xml output to mark failures as such (#632)22d1ef6Update pkg/errors to v0.8.1.4ed1349add kubeedge (#636)d2b1eeabodyclose: fix race conditionf312a0ffix #416: Add skip-dirs-use-default (#630)c5b0f95fix cuncurrent [read/]write paniccdeefb5fix invalid dependencies (#605)e175825fix possible race in line cache7e170affix: body close panic.136b271update bodyclose: use upstream version (#666)e39e8fbupdate x/toolsDocker images
docker pull golangci/golangci-lint:latestdocker pull golangci/golangci-lint:v1.18.0docker pull golangci/golangci-lint:v1.18Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.