resource/ecs_service: Fixes normalization issues in placement_strategy #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #938 When aws_ecs_service has a placement_strategy of type `spread`, you can use a field of `instanceId` or `host` interchangable. BUT AWS will normalize the field value to return `instanceId`. We have introduced a custom Set func to manage this work so that we understand when someone uses `host`, we won't get a diff when AWS return `instanceId` -> if there is a diff, a ForceNew is applied ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsService' ✹ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSEcsService -timeout 120m === RUN TestAccAWSEcsServiceWithARN --- PASS: TestAccAWSEcsServiceWithARN (147.06s) === RUN TestAccAWSEcsServiceWithUnnormalizedPlacementStrategy --- PASS: TestAccAWSEcsServiceWithUnnormalizedPlacementStrategy (116.97s) === RUN TestAccAWSEcsServiceWithFamilyAndRevision --- PASS: TestAccAWSEcsServiceWithFamilyAndRevision (125.69s) === RUN TestAccAWSEcsServiceWithRenamedCluster --- PASS: TestAccAWSEcsServiceWithRenamedCluster (268.02s) === RUN TestAccAWSEcsService_withIamRole --- PASS: TestAccAWSEcsService_withIamRole (155.57s) === RUN TestAccAWSEcsService_withDeploymentValues --- PASS: TestAccAWSEcsService_withDeploymentValues (128.80s) === RUN TestAccAWSEcsService_withLbChanges --- PASS: TestAccAWSEcsService_withLbChanges (242.82s) === RUN TestAccAWSEcsService_withEcsClusterName --- PASS: TestAccAWSEcsService_withEcsClusterName (113.21s) === RUN TestAccAWSEcsService_withAlb --- PASS: TestAccAWSEcsService_withAlb (349.69s) === RUN TestAccAWSEcsServiceWithPlacementStrategy --- PASS: TestAccAWSEcsServiceWithPlacementStrategy (238.08s) === RUN TestAccAWSEcsServiceWithPlacementConstraints --- PASS: TestAccAWSEcsServiceWithPlacementConstraints (123.41s) === RUN TestAccAWSEcsServiceWithPlacementConstraints_emptyExpression --- PASS: TestAccAWSEcsServiceWithPlacementConstraints_emptyExpression (126.25s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 2138.968s ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #938
When aws_ecs_service has a placement_strategy of type
spread, you canuse a field of
instanceIdorhostinterchangable. BUT AWS will normalize thefield value to return
instanceId.We have introduced a custom Set func to manage this work so that we
understand when someone uses
host, we won't get a diff when AWS returninstanceId-> if there is a diff, a ForceNew is applied