deps: Migrate from github.com/hashicorp/terraform to github.com/hashicorp/terraform-plugin-sdk #10253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
dependencies
This was referenced Sep 26, 2019
|
@bflad I'm curious why |
The code within the project doesn't live under $ go get github.com/terraform-providers/terraform-provider-tls@v2.1.1
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1
go get github.com/terraform-providers/terraform-provider-tls@v2.1.1: github.com/terraform-providers/terraform-provider-tls@v2.1.1: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2In fact, updating via Go 1.13 doesn't work at all: $ go get github.com/terraform-providers/terraform-provider-tls@v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go get github.com/terraform-providers/terraform-provider-tls@v2.1.1+incompatible: github.com/terraform-providers/terraform-provider-tls@v2.1.1+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is requiredI used Go 1.12 to workaround ☝️ -- another good reason to get off Terraform Providers as codebase dependencies. |
appilon
approved these changes
Sep 26, 2019
|
Ah yes forgot about that. Well if it compiles then it LGTM |
This was referenced Sep 27, 2019
|
Rebasing due to merging #7627 then probably going to just merge this -- it will be a nightmare to keep rebasing. |
…corp/terraform-plugin-sdk Reference: https://www.terraform.io/docs/extend/plugin-sdk.html Updated via: ```console $ tf-sdk-migrator migrate $ go get github.com/terraform-providers/terraform-provider-tls@v2.1.1+incompatible $ go mod tidy $ go mod vendor ``` Output from acceptance testing (provided as a smoke test): ``` --- PASS: TestAccAWSProvider_Region_AwsCommercial (2.85s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.85s) --- PASS: TestAccAWSProvider_Region_AwsChina (2.86s) --- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.06s) --- PASS: TestAccAWSProvider_Endpoints (3.11s) ```
…shicorp/terraform-plugin-sdk/helper/schema:ForceNew|Set Reference: https://www.terraform.io/docs/extend/plugin-sdk.html Required as part of migrating to the new Terraform Plugin SDK, which changes the import paths from github.com/hashicorp/terraform to github.com/hashicorp/terraform-plugin-sdk.
Reference: https://www.terraform.io/docs/extend/plugin-sdk.html Updated via: ```console $ go get github.com/bflad/tfproviderlint@v0.5.0 $ go mod tidy $ go mod vendor ```
bflad
force-pushed
the
td-terraform-plugin-sdk-migration
branch
from
a1eacc0 to
834ad01
Compare
|
Looks like we have a few conflicts that need to be resolved. |
|
This will be redone after tomorrow's release 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: https://www.terraform.io/docs/extend/plugin-sdk.html
Release note for CHANGELOG:
Updated via:
I will also take a look at quickly switching bflad/tfproviderlint to the new dependency, which may completely remove hashicorp/terraform from the transitive dependencies as well.
Output from acceptance testing (provided as a smoke test):