Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Override renovate semanticCommits auto-detection by always disabling #10266

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 27, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

This project contains both non-semantic and semantic commit messages. Renovate tries to auto-detect which style it should use when submitting dependency update pull requests, however the mixture of the two seems to lead to renovate pull requests that start without the chore(deps) titles, then flip-flop to including it and not including it. This leads to confusing and duplicate pull requests.

Here we just force disable the semantic commit messaging to prevent the changing auto-detection behavior.

References:

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A

…bling

This project contains both non-semantic and semantic commit messages. Renovate tries to auto-detect which style it should use when submitting dependency update pull requests, however the mixture of the two seems to lead to renovate pull requests that start without the `chore(deps)` titles, then flip-flop to including it and not including it. This leads to confusing and duplicate pull requests.

Here we just force disable the semantic commit messaging to prevent the changing auto-detection behavior.

References:

- #10255 and #10262
- #10248 and #10264
- #9991 and #10263
- #10011 (comment)
@bflad bflad added the dependencies Used to indicate dependency changes. label Sep 27, 2019
@bflad bflad requested a review from a team September 27, 2019 12:17
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Sep 27, 2019
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like us to consider using semantic commit messages in the future, but I agree this is the best option for now.

@bflad bflad added this to the v2.31.0 milestone Sep 28, 2019
@bflad bflad merged commit e8c5cd2 into master Sep 28, 2019
@bflad bflad deleted the td-renovate-semanticCommits branch September 28, 2019 01:11
@ghost
Copy link

ghost commented Oct 3, 2019

This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants