-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement QLDB Ledger resource and data lookup #10394
Conversation
@kristiandrucker Thanks for this. 👏 |
@evanphx np. |
@evanphx PR updated |
Thank you @kristiandrucker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kristiandrucker 👋 Thank you for contributing this. Please see the below for an initial review and reach out if you have any questions about the feedback items or do not have time to implement them.
@bflad can you re-review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kristiandrucker 👋 Thanks for those updates, this is shaping up nicely. A few more items and then this should be good to go. Please reach out if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @kristiandrucker, two very minor fixes on merge and pulling this in. 🚀
Output from acceptance testing after test fix:
--- PASS: TestAccAWSQLDBLedger_basic (42.55s)
--- PASS: TestAccAWSQLDBLedger_Tags (59.12s)
--- PASS: TestAccDataSourceAwsQLDBLedger (72.38s)
testAccCheckAWSQLDBLedgerExists(resourceName, &qldbCluster), | ||
testAccMatchResourceAttrRegionalARN(resourceName, "arn", "qldb", regexp.MustCompile(`ledger/.+`)), | ||
resource.TestMatchResourceAttr(resourceName, "name", regexp.MustCompile("test-ledger-[0-9]+")), | ||
resource.TestCheckResourceAttr(resourceName, "permissions_mode", "ALLOW_ALL"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed one check with removal of the attribute:
--- FAIL: TestAccAWSQLDBLedger_basic (40.98s)
testing.go:615: Step 0 error: Check failed: Check 4/6 error: aws_qldb_ledger.test: Attribute 'permissions_mode' not found
Will remove this line on merge.
Output from acceptance testing: ``` --- PASS: TestAccAWSQLDBLedger_basic (42.55s) --- PASS: TestAccAWSQLDBLedger_Tags (59.12s) --- PASS: TestAccDataSourceAwsQLDBLedger (72.38s) ```
* provider: Hashibot issue/PR matching for CloudTrail should not include trailing underscore Reference: #10730 The CloudTrail Trail resource is named just `aws_cloudtrail`. * provider: Hashibot pull request labeling for route53resolver should include underscore Reference: #10348 * provider: Add missing pull request labeling for qldb Reference: #10394 * provider: Fix hashibot pull request labeling for athena Reference: #10609 * provider: Ensure hashibot labeling for apigateway catches aws_api_gateway_vpc_link Reference: #10561
This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #10069
Release note for CHANGELOG:
Output from acceptance testing: