Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/provider: Add .hashibot.hcl changes to New Service checklist #10400

Merged
merged 1 commit into from
Oct 9, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,35 @@ into Terraform.
`quicksightconn: quicksight.New(sess.Copy(&aws.Config{Endpoint: aws.String(c.Endpoints["quicksight"])})),`
- In `website/docs/guides/custom-service-endpoints.html.md`: Add the service
name in the list of customizable endpoints.
- In `.hashibot.hcl`: Add the new service to automated issue and pull request labeling. e.g. with the `quicksight` service

```hcl
behavior "regexp_issue_labeler_v2" "service_labels" {
# ... other configuration ...

label_map = {
# ... other services ...
"service/quicksight" = [
"aws_quicksight_",
],
# ... other services ...
}
}

behavior "pull_request_path_labeler" "service_labels"
# ... other configuration ...

label_map = {
# ... other services ...
"service/quicksight" = [
"**/*_quicksight_*",
"**/quicksight_*",
],
# ... other services ...
}
}
```

- Run the following then submit the pull request:

```sh
Expand Down